Skip to content

Modifies previous persistent volume fix to work on mac as well#70

Merged
dymurray merged 1 commit into
devfrom
mac_fix
Jun 15, 2017
Merged

Modifies previous persistent volume fix to work on mac as well#70
dymurray merged 1 commit into
devfrom
mac_fix

Conversation

@jwmatthews
Copy link
Copy Markdown
Member

I've tested this on Mac.

Need to test on Linux & EC2 next.

Comment thread ansible/reset_local_environment.yml Outdated
- env_hacks
- service_catalog_setup
- ansible_service_broker_setup
- env_hacks
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwmatthews We thought that moving it prior to the Ansible Service Broker Setup role made sense because etcd uses a persistent volume now with the new changes to the template. When etcd first comes up and env_hacks is at the end then the PV directory will not have enough permissions to initially run. I'm not sure if you see any problems running it at the end but I would assume the etcd pod restarts a couple times if the initial mount fails.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll modify and re-test.

Updated all other top level playbooks to place env_hacks
to be after openshift setup
@jwmatthews jwmatthews changed the title [WIP] Modifies previous persistent volume fix to work on mac as well Modifies previous persistent volume fix to work on mac as well Jun 15, 2017
@jwmatthews
Copy link
Copy Markdown
Member Author

Changed logic for detecting when persistent volumes have been created, now we wait for the pod persistent-volume-setup to complete before we adjust permissions.

@dymurray
Copy link
Copy Markdown
Contributor

This worked for me on Linux, I think a change is needed to reset_local_environment to run the env_hacks role after the openshift_setup role. You got every file except for the local one.

@dymurray
Copy link
Copy Markdown
Contributor

Ignore my previous comment, ACK.

@dymurray dymurray merged commit 308846c into dev Jun 15, 2017
@jwmatthews jwmatthews deleted the mac_fix branch June 16, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants