Skip to content

Consolidate local playbooks#73

Merged
dymurray merged 2 commits into
fusor:devfrom
cfchase:playbook-consolidation
Jun 20, 2017
Merged

Consolidate local playbooks#73
dymurray merged 2 commits into
fusor:devfrom
cfchase:playbook-consolidation

Conversation

@cfchase
Copy link
Copy Markdown
Contributor

@cfchase cfchase commented Jun 16, 2017

No description provided.

@cfchase
Copy link
Copy Markdown
Contributor Author

cfchase commented Jun 16, 2017

@jwmatthews what do you think about consolidating our local playbooks and using variables instead?

-p DOCKERHUB_USER={{ dockerhub_user_name }}
-p LAUNCH_APB_ON_BIND={{ broker_launch_apb_on_bind }}
-p OUTPUT_REQUEST={{ broker_output_request }}
-p RECOVERY={{ broker_recovery }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will want to add this back now that the recovery pr has merged

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that, that was unintentional

@cfchase cfchase changed the title [DO NOT MERGE] Consolidate local playbooks Consolidate local playbooks Jun 16, 2017
method: POST
register: response
until: response|success and response.json and response.json.spec_count
until: response|success and response.json and response.json.spec_count is defined
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change keeps catasb from failing whenever someone doesn't have any apbs yet.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jwmatthews
Copy link
Copy Markdown
Member

Would you also update the README's to coincide, assume we need some directions to create my_vars.yml a level up, also some mention of the other .yml being shared in local directory.

Copy link
Copy Markdown
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to deploy using different Broker config options and worked great for me. Good job.

ACK.

dockerhub_org_name: example_org

# Omit this unless you want to store your password in plain text to skip prompts.
# dockerhub_user_password: example_password
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to have a special note about this

@dymurray dymurray merged commit 9bb7726 into fusor:dev Jun 20, 2017
@cfchase cfchase deleted the playbook-consolidation branch July 7, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants