add rcm option and source repetitive code#75
Conversation
jmontleon
changed the title
Member
|
+1 to the approach of --rcm and specifying the different variables in a separate file. |
jwmatthews
reviewed
Jun 16, 2017
|
|
||
| if [ "$1" == "--rcm" ]; then | ||
| shift | ||
| extra_args+='-e @../../rcm_vars.yml' |
Member
There was a problem hiding this comment.
Wondering if this might be a problem running from ec2 directory, assuming this was written for sourcing from "local/linux" or "local/mac" instead of "ec2"
Contributor
Author
There was a problem hiding this comment.
Yes, likely it will be a problem. I'll look at an alternative way of handling it.
Thanks for catching that.
Member
|
I'm working on a rebase and review of this, will update once it's ready. |
Member
|
I attempted to rebase this work in PR 78 |
Member
|
I closed pr 78 since this has been rebased. ACK |
jmontleon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.