[feature] added error messages for resource limits.

[JayaSurya-27]

Pull Request

Description

Describe the changes in this pull request:

• Added appropriate Error messages for resource Limits instead of 500 Internal Sever Error

Checklist

• Code compiles correctly.
• Created/updated tests.
• Linting and formatting applied.
• Documentation updated.

Related Issues

Fixes TH-180

Summary by CodeRabbit

• New Features
  • Added support for the VertexAI provider.
• Bug Fixes
  • Improved error messages for HTTP errors by displaying more detailed server responses when available.

[coderabbitai]

Walkthrough

A new enum value VERTEXAI was added to FiLLMProviderValues. Code in the VertexAI wrapper now uses this constant instead of a hardcoded string. Error handling in the HTTPSpanExporter was improved to extract and display detailed error messages from server responses.

Changes

File(s)	Change Summary
python/fi_instrumentation/fi_types.py	Added VERTEXAI member to the FiLLMProviderValues enum.
python/frameworks/vertexai/traceai_vertexai/_wrapper.py	Replaced hardcoded "vertexai" string with FiLLMProviderValues.VERTEXAI.value for provider name.
python/fi_instrumentation/otel.py	Enhanced HTTP error handling to extract and print server error details from JSON responses.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant HTTPSpanExporter
    participant Server

    Client->>HTTPSpanExporter: export()
    HTTPSpanExporter->>Server: Send HTTP request
    Server-->>HTTPSpanExporter: HTTPError with JSON response
    HTTPSpanExporter->>HTTPSpanExporter: Parse JSON, extract 'result' if present
    HTTPSpanExporter->>Client: Print detailed error message, return failure

Loading

Poem

In the meadow of code where enums grow,
A VertexAI blossom now joins the show.
Errors now whisper their secrets clear,
As exporters listen, and details appear.
No more hardcoded strings to chase,
Just constants—rabbits love this grace!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5c9b8e and 2be7845.

📒 Files selected for processing (3)

• python/fi_instrumentation/fi_types.py (1 hunks)
• python/fi_instrumentation/otel.py (1 hunks)
• python/frameworks/vertexai/traceai_vertexai/_wrapper.py (4 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

python/frameworks/vertexai/traceai_vertexai/_wrapper.py (2)

python/fi_instrumentation/fi_types.py (1)

• FiLLMProviderValues (402-410)

typescript/packages/fi-semantic-conventions/src/trace/SemanticConventions.ts (1)

• LLM_PROVIDER (184-185)

🔇 Additional comments (5)

python/fi_instrumentation/fi_types.py (1)

410-410: LGTM! Good addition to centralize VertexAI provider constant.

The new enum value follows the established pattern and will ensure consistent usage of the VertexAI provider identifier across the codebase.

python/frameworks/vertexai/traceai_vertexai/_wrapper.py (3)

31-31: Good practice: Importing centralized provider values.

This import enables the use of standardized provider constants instead of hardcoded strings.

---

711-711: Well-defined constant for VertexAI provider.

Creating a module-level constant from the enum value maintains consistency with other provider constants in the file.

---

148-148: Excellent refactoring: Replaced hardcoded strings with centralized constant.

Using the VERTEXAI constant instead of hardcoded "vertexai" strings improves maintainability and ensures consistency across the codebase. This change eliminates the risk of typos and makes future updates easier.

Also applies to: 429-429

python/fi_instrumentation/otel.py (1)

561-572: Excellent enhancement: Improved error messaging for HTTP failures.

This change directly addresses the PR objective by extracting detailed error messages from server responses instead of showing generic HTTP errors. The implementation is robust:

• Safely attempts JSON parsing with proper exception handling
• Validates the response structure before extracting error details
• Falls back gracefully to the original error message if parsing fails
• Provides much more actionable error information, especially for resource limit issues

This will significantly improve the user experience when encountering server-side errors, particularly for resource limits that would previously show as generic 500 Internal Server Errors.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.