Skip to content

Conversation

@sarthakFuture
Copy link
Contributor

@sarthakFuture sarthakFuture commented Jun 13, 2025

Pull Request

Description

Describe the changes in this pull request:

  • What feature/bug does this PR address?
  • Provide any relevant links or screenshots.

Checklist

  • Code compiles correctly.
  • Created/updated tests.
  • Linting and formatting applied.
  • Documentation updated.

Related Issues

Closes #<issue_number>

Summary by CodeRabbit

  • New Features

    • Added 27 new evaluation types, including bias detection, content safety, summary quality, compliance, code validation, and scoring metrics, expanding support for diverse evaluation criteria.
  • Documentation

    • Updated terminology in docstrings and package descriptions to reference "TraceAI" and "Google ADK" instead of previous names.
    • Simplified example usage in LangChain integration documentation.
  • Chores

    • Updated test dependencies and imports to use new package names and constants.
    • Removed a virtual environment configuration file.

@coderabbitai
Copy link

coderabbitai bot commented Jun 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update expands evaluation support in the TypeScript core by adding 27 new evaluation types, updates their configurations and mappings, and aligns references from "OpenInference" to "TraceAI" across Python documentation and test code. It also updates dependencies, removes a virtual environment configuration, and adjusts package descriptions and imports for consistency.

Changes

File(s) Change Summary
python/fi_instrumentation/instrumentation/context_attributes.py Docstrings updated to replace "OpenInference" with "TraceAI" in context manager descriptions.
python/frameworks/google-adk/.venv/pyvenv.cfg Deleted Python virtual environment configuration file.
python/frameworks/google-adk/pyproject.toml Package description updated from Anthropic to Google ADK.
python/frameworks/langchain/README.md Removed project_version_name="v1" from trace provider registration example.
python/frameworks/openai-agents/test-requirements.txt Replaced openinference-instrumentation-openai with traceai-openai-agents dependency.
python/frameworks/openai-agents/tests/conftest.py Updated imports to use traceai_openai_agents and traceai_openai modules.
python/frameworks/openai-agents/tests/test_span_attribute_helpers.py Changed import path for helper functions to traceai_openai_agents._processor.
python/frameworks/smolagents/tests/openinference/instrumentation/smolagents/test_instrumentor.py Replaced openinference tracer/constants with fi_instrumentation and traceai_smolagents equivalents in tests.
typescript/packages/fi-core/src/fi_types.ts Added 27 new EvalName enum members; updated getConfigForEval and getMappingForEval for new evals.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EvalModule (fi_types.ts)
    User->>EvalModule: getConfigForEval(evalName)
    EvalModule-->>User: Return config for evalName (including new types)
    User->>EvalModule: getMappingForEval(evalName)
    EvalModule-->>User: Return input/output mapping for evalName
Loading

Possibly related PRs

  • future-agi/traceAI#49: Updates docstrings in the same context manager classes to replace "OpenInference" with "TraceAI."
  • future-agi/traceAI#33: Introduces the initial fi_types.ts module with the EvalName enum and related types/functions, which this PR extends.
  • future-agi/traceAI#43: Adds similar evaluation enum/config expansions in the Python fi_instrumentation module, paralleling this PR's TypeScript changes.

Poem

In burrows deep, a rabbit writes,
Expanding evals for days and nights.
TraceAI now in docs and code,
Old OpenInference off the road.
New imports hop, dependencies pruned,
With every enum, our features ballooned!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e30e671 and 49d6cae.

📒 Files selected for processing (9)
  • python/fi_instrumentation/instrumentation/context_attributes.py (6 hunks)
  • python/frameworks/google-adk/.venv/pyvenv.cfg (0 hunks)
  • python/frameworks/google-adk/pyproject.toml (1 hunks)
  • python/frameworks/langchain/README.md (0 hunks)
  • python/frameworks/openai-agents/test-requirements.txt (1 hunks)
  • python/frameworks/openai-agents/tests/conftest.py (1 hunks)
  • python/frameworks/openai-agents/tests/test_span_attribute_helpers.py (1 hunks)
  • python/frameworks/smolagents/tests/openinference/instrumentation/smolagents/test_instrumentor.py (8 hunks)
  • typescript/packages/fi-core/src/fi_types.ts (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NVJKKartik NVJKKartik merged commit 42a3f94 into main Jun 13, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants