[Feature] Typescript Support for OpenAI, Anthropic and Langchain #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (span is exported now, TODO: Trace and project type)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| import { generateTraceConfig } from "./traceConfig"; | ||
| import { getAttributesFromContext } from "../contextAttributes"; | ||
| // Removed unused imports that were causing linter errors | ||
| // import { INPUT_ATTRIBUTES, ... } from "./constants"; |
Contributor
There was a problem hiding this comment.
can remove these comments
sarthakFuture
requested changes
May 19, 2025
sarthakFuture
requested changes
May 19, 2025
|
|
||
| const CONTEXT_ATTRIBUTES_ATTRIBUTES_KEY = "attributes" as const; | ||
|
|
||
| export const ContextAttributes = { |
Contributor
There was a problem hiding this comment.
review this one and methods like setValue, getValue
Contributor
Author
There was a problem hiding this comment.
these are opentelemetry methods and standards, they are integral to tracing
sarthakFuture
requested changes
May 19, 2025
sarthakFuture
requested changes
May 20, 2025
| * Flag to check if the openai module has been patched | ||
| * Note: This is a fallback in case the module is made immutable (e.x. Deno, webpack, etc.) | ||
| */ | ||
| let _isOpenInferencePatched = false; |
| const onError = (message: string) => (error: unknown) => { | ||
| diag.warn( | ||
| `OpenInference-LangChain: error processing langchain run, falling back to null. ${message}. ${error}`, | ||
| ); |
Contributor
There was a problem hiding this comment.
replace openinference
sarthakFuture
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Describe the changes in this pull request:
pnpm installat ./typescript directorynpx ts-node path/to/script(recommended to usepnpm run build)Use script found in
Checklist
Related Issues
Closes #<issue_number>