fix: replace FullscreenModal with Drawer for non-camera dialogs#142
Closed
fix: replace FullscreenModal with Drawer for non-camera dialogs#142
Conversation
The Vaul library has compatibility issues with the test environment that would require significant workarounds. Reverting to FullscreenModal for EntityBrowser until a more test-friendly drawer solution can be implemented.
Owner
Author
|
Closing this PR due to testing challenges with Vaul library. The library causes issues in the test environment that would require significant workarounds. Will create a follow-up issue to investigate alternative drawer solutions that are more test-friendly. |
…lenges" This reverts commit 70e6668.
- Created proper mock for Vaul library based on GitHub issue solution - Configured vitest to use the mock via resolve alias - All tests now pass with the drawer implementation - Fixed linting and formatting issues
- Add AppTaskbar test to verify add item button behavior - Add Dashboard integration test for entity browser flow - Update existing Dashboard test to verify event handling - Fix nested button issue in ScreenTaskbarButton - Update dashboardStore to accept null for setCurrentScreen
Owner
Author
|
Closing PR due to persistent issues with Vaul drawer implementation. The drawer opens but has dimension/styling issues that are difficult to resolve. Will revisit with a different approach or library in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
Summary
Testing
npm test)npm run lint)npm run typecheck)npm run build:ha)Test Evidence
Implementation Details