Conversation
fxamacker
force-pushed
the
fxamacker/refactor-indefinite-length-encoding
branch
from
4937e43 to
1b36774
Compare
Previously, the encoder rejected invalid chunks in indefinite-length strings based on the Go type. This could mistakenly reject objects that don't match the expected Go type, even if they encode valid chunk data (e.g., with a user-defined CBORMarshaler), and vice versa. This commit validates a chunk by inspecting the encoded chunk's CBOR type to ensure that the encoded chunk data is definite-length items of the same major type as the parent.
fxamacker
force-pushed
the
fxamacker/refactor-indefinite-length-encoding
branch
from
1b36774 to
0cdb674
Compare
x448
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors indefinite-length encoding and improves chuck validation during encoding.
Previously, the encoder rejected invalid chunks in indefinite-length strings based on the Go type. This could mistakenly reject objects that don't match the expected Go type, even if they encode valid chunk data (e.g., with a user-defined CBORMarshaler), and vice versa.
This PR validates a chunk by inspecting the encoded chunk's CBOR type to ensure that the encoded chunk data is definite-length items of the same major type as the parent.