Skip to content

Feature/Add-Checkout-Button #4

Open
parizat-hridi wants to merge 1 commit intomainfrom
feature/checkout-button
Open

Feature/Add-Checkout-Button #4
parizat-hridi wants to merge 1 commit intomainfrom
feature/checkout-button

Conversation

@parizat-hridi
Copy link
Collaborator

Added a checkout button.

@parizat-hridi parizat-hridi added the enhancement New feature or request label Jul 15, 2021
@parizat-hridi parizat-hridi requested a review from foysalit July 15, 2021 17:33
@parizat-hridi parizat-hridi self-assigned this Jul 15, 2021
@parizat-hridi parizat-hridi changed the title Next Shop Feature/Add-Checkout-Button Jul 15, 2021
Copy link
Contributor

@foysalit foysalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a screenshot/some detail to your PR description always helps.

<button className="button">Continue</button>
</div>

);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sent another PR, trying to focus on indentation. Added relevant pictures also. Thanks for your feedback.

margin: 0;
}

h1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! so much css. the point of tailwind is not to write much css, especially not the stuff that tailwind supports out of the box. any reason why you decided to stick to raw css over tailwind?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason actually. I'm not used to the tailwind. Definitely, I'm gonna try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants