Conversation
… improve subscription logic
pkg/event/keygen.go
Outdated
There was a problem hiding this comment.
is cggmp21_pub_key ecdsa or eddsa?
I think in keygen, sign event payload. We pass algorithm: Enum : gg18/20 | cggmp21 | ...
In the result event, we use ECDSAPubKey, EDDSAPubKey onl
There was a problem hiding this comment.
type MPCAlgorithm string
const (
// Threshold ECDSA family (GG18/GG20)
MPCAlgorithmGG MPCAlgorithm = "gg18/20"
// Advanced threshold ECDSA (modern successors)
MPCAlgorithmCGGMP21 MPCAlgorithm = "cggmp21"
// Threshold Schnorr family
MPCAlgorithmFROST MPCAlgorithm = "frost"
MPCAlgorithmTaproot MPCAlgorithm = "taproot"
)There was a problem hiding this comment.
currently all three cggmp21, frost, and taproot only support ECDSA
pkg/eventconsumer/event_consumer.go
Outdated
There was a problem hiding this comment.
Should we call it CreateCGGMP21Session to be more generic
There was a problem hiding this comment.
This one’s a factory that sets up sessions for all protocols (CGGMP21, FROST, Taproot). Keeping it generic makes sign/presign creation cleaner and the code easier to read.
| type TaurusMessage struct { | ||
| SID string | ||
| From string | ||
| To []string | ||
| IsBroadcast bool | ||
| Data []byte | ||
| Signature []byte |
There was a problem hiding this comment.
Not sure if this Taurus Message is necessary, can we use existing events in initiator_msg.go
There was a problem hiding this comment.
yeah this one’s like a generic TssMessage wrapper for protocol transport, not the same as the initiator events
|
The pull request lacking pratical examples for cggmp21 + taproot + frost signing. May need to add more examples in |
… remove wallets.json
…g with new data structures
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|

PR Summary
Implement all Taurus protocols (CMP, FROST, Taproot) and add Presign support for CMP (CGGMP21).
Presign for CMP (CGGMP21)
Presignbefore signing a transaction.