Conversation
Fix duplicate message + bug can't sign transaction when nodes restart
anhthii
reviewed
Apr 12, 2025
anhthii
force-pushed
the
feature/persit-sign-event
branch
from
9071d18 to
9602d4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.0.0 Release Notes
Overview
This major release enhances the resiliency and reliability of mpcium’s threshold signature operations. Key changes focus on persisting signing events, improving timeout and duplicate message handling, and ensuring smooth operation even when some nodes are in backup mode.
Changes
Feature Enhancements
Persist Signing Events:
The system now persists sign messages to help ensure that failure or timeout scenarios are handled gracefully. This improvement increases the overall resiliency of the signing process.
OnSuccess Callback for Signing Sessions:
The signing workflow now leverages an onSuccess callback to confirm a successful sign session. This ensures that messages are acknowledged properly and reduces the risk of redelivery.
Improved Timeout Handling:
Bug Fixes
Duplicate Message Handling:
Improved logic to detect and handle duplicate messages, reducing redundant processing and related errors.
Backup Nodes Bug Fix:
Fixed an issue where signing did not proceed when all nodes were in backup mode, ensuring consistent operation under varying cluster conditions.
Merged Contributions
Acknowledgements
Special thanks to the contributors—Poseidon-G, Luc Nguyen, fystack, anhthii, and all others—for their efforts in reviewing and committing changes that have made this release possible.
We recommend updating to v2.0.0 to benefit from these important improvements in resiliency and overall functionality.