Support resharing

[vietddude]

1. Resharing is available for both ECDSA (secp256k1) and EdDSA (ed25519) key types.
2. Initiators can specify a custom set of peer IDs (available) to participate in the new committee.
3. Backward compatibility

[anhthii]

bugbot run

[anhthii]

bugbot run

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License

View full report

[anhthii]

bugbot run

[anhthii]

Fix #25 with commit 0d99150

[anhthii]

bugbot run

[anhthii]

bugbot run

[anhthii]

bugbot run

[cursor]

Bug: JSON Unmarshaling Errors Mask Important Data

When JSON unmarshaling fails for GenerateKeyMessage or ResharingMessage, the uninitialized (zero-valued) fields of the msg struct are subsequently passed to their respective error handling functions. This results in incomplete and misleading error logs, as identifiers like WalletID, KeyType, or NewThreshold will be empty or zero.

pkg/eventconsumer/event_consumer.go#L482-L487

mpcium/pkg/eventconsumer/event_consumer.go

Lines 482 to 487 in e808958

	var msg types.ResharingMessage
	if err := json.Unmarshal(natMsg.Data, &msg); err != nil {
	logger.Error("Failed to unmarshal resharing message", err)
	ec.handleReshareSessionError(msg.WalletID, msg.KeyType, msg.NewThreshold, err, "Failed to unmarshal resharing message")
	return
	}

pkg/eventconsumer/event_consumer.go#L124-L127

mpcium/pkg/eventconsumer/event_consumer.go

Lines 124 to 127 in e808958

	var msg types.GenerateKeyMessage
	if err := json.Unmarshal(raw, &msg); err != nil {
	logger.Error("Failed to unmarshal keygen message", err)
	ec.handleKeygenSessionError(msg.WalletID, err, "Failed to unmarshal keygen message")

Fix in Cursor • Fix in Web

---

Bug: Server Crashes on Unknown Session Type

The getVersion function calls logger.Fatal when an unknown session type is encountered, causing the server to crash. This violates PR guidelines against panicking in production and should be replaced with an error return.

pkg/mpc/node.go#L503-L505

mpcium/pkg/mpc/node.go

Lines 503 to 505 in e808958

	default:
	logger.Fatal("Unknown session type", errors.New("Unknown session type"))
	}

Fix in Cursor • Fix in Web

---

Bug: Reshare Session Fails for New Peers

The ensureNodeIsParticipant check in CreateReshareSession is incorrectly applied to new peers (isNewPeer=true) during resharing. New peers are not part of the old committee, but the check validates against oldKeyInfo.ParticipantPeerIDs, preventing them from participating.

pkg/mpc/node.go#L339-L343

mpcium/pkg/mpc/node.go

Lines 339 to 343 in e808958

	if err := p.ensureNodeIsParticipant(oldKeyInfo); err != nil {
	return nil, err
	}

Fix in Cursor • Fix in Web

---

Bug: Signing Event Handling Fails to Acknowledge Messages

When handleSigningEvent detects insufficient peers to process a signing request, it returns without acknowledging or negatively acknowledging the JetStream message. This leaves the message unacknowledged, potentially causing redelivery loops, timeouts, or queue blocking.

pkg/eventconsumer/sign_consumer.go#L133-L140

mpcium/pkg/eventconsumer/sign_consumer.go

Lines 133 to 140 in e808958

	if readyPeers < requiredPeers {
	logger.Warn("SigningConsumer: Not enough peers to process signing request, rejecting message",
	"ready", readyPeers,
	"required", requiredPeers)
	return
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎