Fix error message when signing with duplicate tx_id (Issue #60)#63
Merged
anhthii merged 2 commits intofystack:masterfrom Jul 30, 2025
Merged
Fix error message when signing with duplicate tx_id (Issue #60)#63anhthii merged 2 commits intofystack:masterfrom
anhthii merged 2 commits intofystack:masterfrom
Conversation
Contributor
|
@Azzurriii Thanks for the PR
In the error reason, I noticed "Duplicate signing request detected" two times
|
Contributor
Author
|
Hey @anhthii, in those two instances of 'Duplicate signing request detected', one is an error message and the other is part of the context. You can see that in the log of mpcium |
anhthii
reviewed
Jul 30, 2025
anhthii
approved these changes
Jul 30, 2025
Contributor
|
thanks @Azzurriii , LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Enhance error handling and improve the detection of duplicate signing requests in the event processing system regarding the Issue #60 . Include adding a new error code for duplicate sessions and updating the logic to handle duplicate signing requests.
pkg/event/types.go: Added a new case in theGetErrorCodeFromErrorfunction to returnErrorCodeSessionDuplicatewhen the error string contains "duplicate". This improves the granularity of error categorization.pkg/eventconsumer/event_consumer.go: Enhanced theconsumeTxSigningEventfunction to handle duplicate signing requests. If a duplicate session is detected, an error message is logged, and the signing session error is handled explicitly using thehandleSigningSessionErrormethod. This ensures better tracking and management of duplicate requests.Testing
Sent duplicate signing requests with the same tx_id.


Verified that the mpcium logs the duplicate and the client receives the error event in
onSignResult