Enhance error handle when signing with duplicate tx_id (Issue #60)#68
Merged
anhthii merged 6 commits intofystack:masterfrom Aug 5, 2025
Merged
Enhance error handle when signing with duplicate tx_id (Issue #60)#68anhthii merged 6 commits intofystack:masterfrom
anhthii merged 6 commits intofystack:masterfrom
Conversation
anhthii
reviewed
Aug 3, 2025
Contributor
|
Can we implement a composeIdempotentKey that both keygen and signing can reuse @Azzurriii please? |
Contributor
Author
|
That's a good idea @anhthii - I'll implement it. key := fmt.Sprintf(mpc.TypeReshareWalletResultFmt, walletID)
err = ec.reshareResultQueue.Enqueue(key, reshareResultBytes, &messaging.EnqueueOptions{
IdempotententKey: key,
}) |
Contributor
|
yes, we can apply apply for reshare as well |
Contributor
Author
|
Thanks! I’ve implemented it. Please take a look!
|
anhthii
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When signing through
mpcClient.SignTransaction, if the sametx_idis used multiple times,mpcClient.OnSignResultcould not receive all results reliably. This happened because:tx_idtx_id)The issue was in the idempotent key generation for NATS messages. The signing sessions used only the
tx_idas the idempotent key:How the Fix Works
SessionIDfrom the NATS message header{tx_id}:{session_id}NATS Message
Raw Data:
Headers:
Nats-Msg-Id: duplicate-test-1754222214845:b7325da2-abd9-4c08-b889-88fddb657af7Testing
From my end, I tested by sending 5 signing requests with the same tx_id.
Only the first request succeeded
The others correctly returned
ERROR_SESSION_DUPLICATE