Conversation
#71) * fix typo * draft impl for diffie hellman exchange * New Feature: add p2p channel among nodes, enabling authenticated encryption * decrease delay * suppress warning * increase delay for starting client * increase delay in test case, supporess github security warning * fix p2p feature correctness * fix p2p feature * fix format error * revert old testing config * correct log & remove useless comment * avoid p2p message via nats message layer * change to modern x25519 curve for ecdh * Minor cleanup * Consistent naming convention Id -> ID * Wait for ECDH session to complete before starting consumers * Code refactoring, better naming convention * Refactor aes encryption * Error handling for ecdh session * Refactor session * Fix security warning on AES encryption * Update ci/cd --------- Co-authored-by: anhthii <nguyendanganhthi247@gmail.com>
Fix lint issue
…peer suddenly dies
Enhanced MPC Cluster Resilience and Error Handling
Enhanced MPC Cluster Resilience and Error Handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address the proposal #66
Related PR: #71
Summary
This PR introduces significant improvements to the MPC (Multi-Party Computation) cluster's resilience and error handling capabilities. The changes focus on making the system more robust when dealing with node disconnections, rejoin scenarios, and ensuring proper error handling during key generation and signing operations.
Key Changes
ECDH Service Refactoring
Enhanced Error Handling
Improved Robustness
Files Modified
cmd/mpcium/main.go- Simplified main application logicpkg/event/types.go- Added new error types for better error classificationpkg/eventconsumer/keygen_consumer.go- Enhanced key generation with cluster readiness checkspkg/eventconsumer/sign_consumer.go- Improved signing with majority validation and error handlingpkg/identity/identity.go- Better identity state managementpkg/mpc/key_exchange_session.go- Refactored for improved session handlingpkg/mpc/node.go- Simplified node management logicpkg/mpc/registry.go- Significantly enhanced registry with better node lifecycle managementImpact