Set SVG Height based on max of column lengths. #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the height of the SVG is set based on the height of the first column. This works when the first round of the bracket is completely full. However, if the bracket is sparse (i.e. bye rounds are not shown), then it's possible for the first column to have fewer matches (and therefore be shorter) than later columns. To fix this, I have updated the calls to `calculateSVGDimensions`. Before, the numOfRows param was always set to the length of columns[0]. Now, it is set to the maximum length of all columns.
EjPlatzer
force-pushed
the
fix/svg-height-max-of-columns
branch
from
292937a to
ecd6bc4
Compare
Contributor
|
If you could, please re-open this Pull request in the project's new repository since this repository has no maintainers with access to it anymore more details here #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the height of the SVG is set based on the length of the first column. This works when the first round of the bracket is completely full. However, if the bracket is sparse (i.e. bye rounds are not shown), then it's possible for the first column to have fewer matches (and therefore be shorter) than later columns.
To fix this, I have updated the calls to
calculateSVGDimensions. Before, the numOfRows param was always set to the length of columns[0]. Now, it is set to the maximum length of all columns.