date-change callback - distinguish explicit selection#250
Open
jharting wants to merge 1 commit intog00fy-:masterfrom
Open
date-change callback - distinguish explicit selection#250jharting wants to merge 1 commit intog00fy-:masterfrom
jharting wants to merge 1 commit intog00fy-:masterfrom
Conversation
…alled for an explicit date selection or something like next()/prev()
|
Why not just make the date picker never change the model unless a date is picked? What is the reasoning behind having the date update when the user is browsing the calendar? |
Contributor
Author
|
I do not know. It does not make sense to me either. However, given that this behavior is already in place I implemented the change with an additional param so that the change does not break existing users. |
dumitru
approved these changes
Sep 30, 2016
|
Also will be more "explicit" if in callbackOnSetDate will be passed view. Now in our projects we use this pull request with minor change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it possible for the date-change callback to distinguish between explicit and implicit date changes. An explicit date change happens when a user explicitly select an option (e.g. a given day in the date view). An implicit date change happens e.g. in next()/prev() navigation.
Before this change there is no way to distinguish what exactly the user is doing. This change is useful when an app needs to perform an action when a user selects an option (e.g. a day).