-
Notifications
You must be signed in to change notification settings - Fork 54
RISC-V RVV: Boost Chameleon to 494 MB/s, Fix Tests WIP #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5abfad4
Add RVV vectorization to Chameleon encoding for performance boost
Dayuxiaoshui e945771
fix error
Dayuxiaoshui bdb4aeb
fix errors
Dayuxiaoshui 5080983
Update codec.rs
Dayuxiaoshui 54efa9b
Update chameleon.rs
Dayuxiaoshui e9501a7
feat:fix error
Dayuxiaoshui 7b66862
feat:fix error
Dayuxiaoshui b2e231f
feat:fix error
Dayuxiaoshui e7573d0
Merge branch 'g1mv:main' into main
Dayuxiaoshui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,12 @@ | ||
| // File: src/codec/quad_encoder.rs | ||
|
|
||
| use crate::io::write_buffer::WriteBuffer; | ||
| use crate::io::write_signature::WriteSignature; | ||
|
|
||
| pub trait QuadEncoder { | ||
| /// 编码单个 u32 quad | ||
| fn encode_quad(&mut self, quad: u32, out_buffer: &mut WriteBuffer, signature: &mut WriteSignature); | ||
| } | ||
|
|
||
| /// 批量编码 u32 quads,支持 RVV 或标量实现 | ||
| fn encode_batch(&mut self, quads: &[u32], out_buffer: &mut WriteBuffer, signature: &mut WriteSignature); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my tests during development, I found that splitting the block into 128-bit sub-blocks and then extracting 4 quads using shift-masking was faster than iterating over each quad as you do here - see the initial
codec.rsfile for that:I suspect this is because the Rust compiler could easily optimize the code (sequential
self.encode_quad()calls).