Skip to content

Add additional params to check if more data in response is needed #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppavlovic merged 2 commits into from
Feb 21, 2024
Merged

Add additional params to check if more data in response is needed #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3f490f
Add additional params to check if more data in response is needed
UrosPurtic Feb 9, 2024
1a76816
Add additional params to check if more data in response is needed
UrosPurtic Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/Profiler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ class Profiler
*/
private $logLevel;

/**
* @var int
*/
private $threshold;

public function __construct()
{
$this->profilers = [];
Expand Down Expand Up @@ -59,12 +64,18 @@ public function setLogLevel($logLevel)
return $this;
}

public function setThreshold($threshold)
{
$this->threshold = (int) $threshold;
return $this;
}

/**
* @return array
*/
public function getProfilerOutput($httpCode, $dbProfiler = 0)
public function getProfilerOutput($httpCode, $dbProfiler = 0, $responseElapsedTime = 0)
{
return $this->hasProfilers() && $this->shouldLogProfiler($httpCode)
return $this->hasProfilers() && $this->shouldLogProfiler($httpCode, $responseElapsedTime)
? $this->getFormatted($dbProfiler)
: [];
}
Expand All @@ -74,17 +85,27 @@ public function getProfilerSummary()
return (new ProfilerSummary($this->profilers))->getSummary();
}

private function shouldLogProfiler($httpCode)
private function shouldLogProfiler($httpCode, $responseElapsedTime)
{
if ($this->logLevel === self::LOG_OFF) {
return false;
}
if ($this->logLevel === self::LOG_ALWAYS) {
return true;
}

if($this->threshold && $responseElapsedTime > $this->threshold){
return true;
}

return self::LOG_ERRORS_ONLY && substr($httpCode, 0, 1) != 2;
}

public function shouldLogProfilerOutput($responseElapsedTimeInMs)
{
return $responseElapsedTimeInMs > $this->threshold;
Copy link
Contributor

@ppavlovic ppavlovic Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if you don't set a threshold value?

}

/**
* @return array
*/
Expand Down
6 changes: 6 additions & 0 deletions src/RunnerAbstract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ public function setProfilerLogLevel($profilerLogLevel)
return $this;
}

public function setProfilerLogThreshold($threshold)
{
$this->profiler->setThreshold($threshold);
return $this;
}

/**
* @return Profiler
*/
Expand Down