Open
Conversation
- Documents all 4 root causes and 3 fixes applied - Includes testing results and verification steps - Provides manual verification checklist for GitHub secrets - Details Sunbiz system completion requirements - Adds emergency recovery procedures - Tracks implementation timeline and metrics
|
🚅 Deployed to the ConcordBroker-pr-28 environment in ConcordBroker-Railway
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Reviewer's GuideThis PR adds a new CI job to enforce that code changes include a changeset file, provides the corresponding .changeset patch entry, and introduces a comprehensive scraper fixes report document. Flow diagram for changeset-check job logicflowchart TD
A["Start changeset-check job"]
B["Checkout code"]
C["Get base and head commit SHAs"]
D["List changed files"]
E["Are code-related paths changed?"]
F["Check for .changeset/*.md file"]
G["Pass job"]
H["Fail job with error"]
A --> B --> C --> D --> E
E -- Yes --> F
F -- Found --> G
F -- Not found --> H
E -- No --> G
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
railway-app
bot
had a problem deploying
to
ConcordBroker (ConcordBroker-Railway / ConcordBroker-pr-28)
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The huge SCRAPER_FIXES_COMPLETE_REPORT.md addition seems unrelated to the CI check and should be moved to a separate PR or docs directory to keep this change focused.
- Consider using the official changesets/action GitHub Action instead of a custom bash diff to make the changeset check more maintainable and robust.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The huge SCRAPER_FIXES_COMPLETE_REPORT.md addition seems unrelated to the CI check and should be moved to a separate PR or docs directory to keep this change focused.
- Consider using the official changesets/action GitHub Action instead of a custom bash diff to make the changeset check more maintainable and robust.
## Individual Comments
### Comment 1
<location> `.github/workflows/pr-checks.yml:25-28` </location>
<code_context>
+ CHANGED=$(git diff --name-only "$BASE_SHA".."$HEAD_SHA")
+ echo "$CHANGED" | sed 's/^/ - /'
+ # If code-related paths changed, require a changeset file
+ if echo "$CHANGED" | grep -E '^(apps/|scripts/|mcp-server/|package\.json|apps/web/|apps/langchain_system/)'; then
+ if ls .changeset/*.md >/dev/null 2>&1; then
+ echo "Changeset found"
</code_context>
<issue_to_address>
**suggestion (bug_risk):** The grep pattern may miss changes in nested files or directories.
The pattern only matches top-level files. Update it to match nested files as well, such as by using a recursive pattern or a more robust method.
```suggestion
# If code-related paths changed, require a changeset file
if echo "$CHANGED" | grep -E '^(apps/|scripts/|mcp-server/|package\.json|apps/web/|apps/langchain_system/)' >/dev/null || \
echo "$CHANGED" | grep -E '^(apps/|scripts/|mcp-server/|apps/web/|apps/langchain_system/)[^/]+/.+' >/dev/null; then
if ls .changeset/*.md >/dev/null 2>&1; then
echo "Changeset found"
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+25
to
+28
| # If code-related paths changed, require a changeset file | ||
| if echo "$CHANGED" | grep -E '^(apps/|scripts/|mcp-server/|package\.json|apps/web/|apps/langchain_system/)'; then | ||
| if ls .changeset/*.md >/dev/null 2>&1; then | ||
| echo "Changeset found" |
There was a problem hiding this comment.
suggestion (bug_risk): The grep pattern may miss changes in nested files or directories.
The pattern only matches top-level files. Update it to match nested files as well, such as by using a recursive pattern or a more robust method.
Suggested change
| # If code-related paths changed, require a changeset file | |
| if echo "$CHANGED" | grep -E '^(apps/|scripts/|mcp-server/|package\.json|apps/web/|apps/langchain_system/)'; then | |
| if ls .changeset/*.md >/dev/null 2>&1; then | |
| echo "Changeset found" | |
| # If code-related paths changed, require a changeset file | |
| if echo "$CHANGED" | grep -E '^(apps/|scripts/|mcp-server/|package\.json|apps/web/|apps/langchain_system/)' >/dev/null || \ | |
| echo "$CHANGED" | grep -E '^(apps/|scripts/|mcp-server/|apps/web/|apps/langchain_system/)[^/]+/.+' >/dev/null; then | |
| if ls .changeset/*.md >/dev/null 2>&1; then | |
| echo "Changeset found" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the changeset-check job to the PR checks workflow to enforce that code changes include a changeset file. This ensures proper version tracking and changelog generation.
Summary by Sourcery
Add a GitHub Actions job to enforce that code changes include a .changeset file and update documentation with a complete scraper fixes report
CI:
Documentation:
Chores: