Integrate Hackathon vrs-in-a-box into vrs-python #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@larrybabb and @theferrit32. As discussed at the think tank, I have started the work to integrate vrs-in-a-box into vrs-python. I think there are a still a few outstanding items. My idea here is that I am throwing this over the fence to you to wrap up. |
Contributor
Contributor
Author
|
@theferrit32 Done. Tests are failing in Python 3.13 for some unrelated reason. |
larrybabb
approved these changes
Dec 17, 2025
Contributor
larrybabb
left a comment
larrybabb
left a comment
There was a problem hiding this comment.
per think tank review - approved
korikuzma
reviewed
Dec 17, 2025
|
|
||
| # Either 'GRCh38' or 'GRCh37' | ||
| ARG ASSEMBLY="GRCh38" | ||
| ARG VRS_PYTHON_VERSION="2.1.2" |
Contributor
There was a problem hiding this comment.
Suggested change
| ARG VRS_PYTHON_VERSION="2.1.2" | |
| ARG VRS_PYTHON_VERSION="2.2.0" |
david4096
reviewed
Dec 17, 2025
| # GRCh38 | ||
| docker build --build-arg ASSEMBLY=GRCh38 --build-arg VRS_PYTHON_VERSION=2.1.2 -t ga4gh/vrs-vcf-annotator-grch38:2.1.2 . | ||
| # GRCh37 | ||
| docker build --build-arg ASSEMBLY=GRCh37 --build-arg VRS_PYTHON_VERSION=2.1.2 -t ga4gh/vrs-vcf-annotator-grch37:2.1.2 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved code from the Hackathon vrs-in-a-box project over in to a subdirectory within vrs-python.
The code includes full instructions for how to create a vrs-in-a-box Docker image from scratch
and examples for how to run using Docker.
The following items are (probably) still needed to bring this work to completion: