Use WeakMap if available to avoid O(n) lookup #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function addProxy(Component, proxy) { | ||
| allProxies.push([Component, proxy]); | ||
| if (!global.WeakMap) { | ||
| global.WeakMap = class WeakMap { |
Owner
There was a problem hiding this comment.
We can’t modify globals. This would really catch users by surprise.
Owner
|
I’m fairly sure this is almost never a bottleneck compared to the actual work updating the component tree. I think we can take something like this, but it has to not override the globals. Maybe defining something like |
Owner
|
Also please note 1.x branch will not be maintained anymore. Please send PRs against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get it WeakMap sometimes fails to load, but avoiding it completely is too harsh, especially I imagine native implementation can be faster than O(n) lookup.