chore: upgrade to polkadot-v0.9.29 by enthusiastmartin · Pull Request #571 · galacticcouncil/Basilisk-node

enthusiastmartin · 2022-10-31T12:36:59Z

Changes:

Weight type changed from u64 to a struct.
math lib contains changes in lbp math (rounding fixed by colin) and improved pow accuracy
removed Exchange pallet
removed LBP and XYK rpcs
Weights updated

github-actions · 2022-10-31T12:40:42Z

Crate versions that have been updated:

runtime-integration-tests: v0.8.0 -> v0.8.1
parachain-runtime-mock: v0.1.0 -> v0.1.1
basilisk: v7.1.0 -> v8.0.0
pallet-duster: v3.1.4 -> v3.1.5
pallet-lbp: v4.5.0 -> v4.6.0
pallet-marketplace: v4.0.1 -> v5.0.0
pallet-xyk: v6.0.0 -> v6.0.1
pallet-xyk-liquidity-mining: v1.0.1 -> v1.0.2
pallet-xyk-liquidity-mining-benchmarking: v1.0.0 -> v1.0.1
primitives: v6.3.4 -> v6.3.5
basilisk-runtime: v80.0.0 -> v81.0.0
common-runtime: v2.2.3 -> v2.2.4
testing-basilisk-runtime: v80.0.0 -> v81.0.0

Runtime version has been increased.

…r precision

codecov · 2022-11-02T12:08:56Z

Codecov Report

Base: 80.04% // Head: 81.11% // Increases project coverage by +1.07% 🎉

Coverage data is based on head (050809f) compared to base (1a99f62).
Patch coverage: 3.94% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   80.04%   81.11%   +1.07%     
==========================================
  Files          26       18       -8     
  Lines        2636     1949     -687     
==========================================
- Hits         2110     1581     -529     
+ Misses        526      368     -158

Impacted Files	Coverage Δ
pallets/marketplace/src/lib.rs	`91.83% <ø> (ø)`
pallets/marketplace/src/migration.rs	`0.00% <0.00%> (ø)`
pallets/xyk-liquidity-mining/src/lib.rs	`84.89% <ø> (ø)`
pallets/xyk-liquidity-mining/src/migration.rs	`36.36% <ø> (ø)`
primitives/src/constants.rs	`0.00% <ø> (ø)`
...ntegration-tests/parachain-runtime-mock/src/lib.rs	`62.79% <50.00%> (-0.63%)`	⬇️
pallets/lbp/src/benchmarking.rs	`98.64% <100.00%> (ø)`
pallets/xyk/src/lib.rs	`84.65% <0.00%> (-1.33%)`	⬇️
...llets/xyk-liquidity-mining/benchmarking/src/lib.rs	`92.34% <0.00%> (+0.03%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

integration-tests/src/fees.rs

node/Cargo.toml

# Conflicts: # pallets/marketplace/Cargo.toml # pallets/marketplace/src/migration.rs

mrq1911 · 2022-11-03T02:25:44Z

runtime/basilisk/src/lib.rs

 	frame_system::ChainContext<Runtime>,
 	Runtime,
-	AllPalletsReversedWithSystemFirst,
+	AllPalletsWithSystem,


@enthusiastmartin why did this change? no change in construct_runtime! is required?

@enthusiastmartin why did this change? no change in construct_runtime! is required?

AllPalletsReversedWithSystemFirst is deprecated in favor of this.

i am aware of it, but it also changes orders in which are pallets loaded, see
paritytech/substrate#10043

enthusiastmartin added 4 commits October 30, 2022 13:00

upgrade to polkadot-v0.9.29

203a9dc

fix lbp tests

17fbf3e

Merge branch 'master' into polkadot-v0.9.29

66924ec

use latest commits

61d0106

dmoka and others added 25 commits October 31, 2022 16:45

fix lbp integration tests

d51f3f1

formatting

d911bdd

fixed lbp unit tests - event ordering and amount changes due to bette…

a215020

…r precision

fix missing invert tests

79beadb

update marketplace migration

a983bd0

fix xyk-lm migration

bdca9f0

use patch polkadot

3fab7ba

remove exchange pallet

d79c1c8

remove redundant into

a687ea5

happy clippy happy life

dab076b

Merge branch 'master' into polkadot-v0.9.29

af1615c

remove offchain duster unused pallet

1c7b837

bump versions

9b7ee14

add missing check for max_royalty to migration

ffac16b

bump crate version

91240aa

remove try runtime from testing runtime

07ea4b6

add try-runtime features to pallets

79a5670

fix build with try-runtime features

dda6613

Merge branch 'master' into polkadot-v0.9.29

68df9b6

update integration tests new package to 29

d3edbda

formatting

8e79617

formatting strikes back

ccb6c89

package version police warning

a683320

fix parachain mock runtime weights

eea440d

fix lbp benchmark tests

00288dc

enthusiastmartin added 3 commits November 2, 2022 12:34

upgrade the remaining 28 references

af2741e

remove XYK and LBP rpcs

e7870bb

happy clippy happy life

09a6501

enthusiastmartin requested review from Roznovjak, dmoka, martinfridrich and mrq1911 November 2, 2022 12:14

enthusiastmartin and others added 3 commits November 2, 2022 14:15

Merge branch 'master' into polkadot-v0.9.29

3f5518b

update weights

b38cc1a

updated fees in tegration tests

c24d8cc

Roznovjak approved these changes Nov 2, 2022

View reviewed changes

integration-tests/src/fees.rs Outdated Show resolved Hide resolved

node/Cargo.toml Outdated Show resolved Hide resolved

mrq1911 added 5 commits November 3, 2022 02:19

Merge branch 'feat/marketplace_migration' into polkadot-v0.9.29

5036501

# Conflicts: # pallets/marketplace/Cargo.toml # pallets/marketplace/src/migration.rs

lock

24bfd86

rich knows

a1d4fb4

merge fix

4524bd7

fmt

ef05714

mrq1911 reviewed Nov 3, 2022

View reviewed changes

mrq1911 and others added 7 commits November 3, 2022 12:12

fixed runtime upgrade test

6e3c9ab

keeping AllPalletsReversedWithSystemFirst

9d45852

add additional check and logs to marketplace migration

33571da

formatting

e0edf6d

refactor marketplace migration

fc00c70

update marketplace migration to deal with invalid values

8c6df9a

formatting

050809f

mrq1911 approved these changes Nov 3, 2022

View reviewed changes

mrq1911 merged commit c2093c9 into master Nov 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade to polkadot-v0.9.29#571

chore: upgrade to polkadot-v0.9.29#571
mrq1911 merged 47 commits intomasterfrom
polkadot-v0.9.29

enthusiastmartin commented Oct 31, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Oct 31, 2022 •

edited

Loading

Uh oh!

codecov bot commented Nov 2, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mrq1911 Nov 3, 2022 •

edited

Loading

Uh oh!

enthusiastmartin Nov 3, 2022

Uh oh!

mrq1911 Nov 3, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

enthusiastmartin commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

mrq1911 Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enthusiastmartin Nov 3, 2022

Choose a reason for hiding this comment

Uh oh!

mrq1911 Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

enthusiastmartin commented Oct 31, 2022 •

edited

Loading

github-actions bot commented Oct 31, 2022 •

edited

Loading

codecov bot commented Nov 2, 2022 •

edited

Loading

mrq1911 Nov 3, 2022 •

edited

Loading

mrq1911 Nov 3, 2022 •

edited

Loading