Skip to content

Conversation

@jaydee029
Copy link
Member

jaydee029 and others added 7 commits August 10, 2024 10:39
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
Signed-off-by: dhruv <dhruvj797@gmail.com>
added build and pr build workflows
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Member

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be made for this one please - also it seems you're missing a docker build step of the simplatform jar image in the PR build, if you could add that that would be great, thanks.

jaydee029 and others added 2 commits August 12, 2024 23:37
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

@jaydee029
Copy link
Member Author

Changes to be made for this one please - also it seems you're missing a docker build step of the simplatform jar image in the PR build, if you could add that that would be great, thanks.

Didn't realize i missed it, fixed it now.

Copy link
Member

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - I'll merge on your behalf when the Galasa 0.36.0 release is done

Copy link
Member

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build successful

Copy link
Member

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed an error when I ran the workflow - please can you make these two updates?

jaydee029 and others added 2 commits August 19, 2024 23:10
Signed-off-by: dhruv <dhruvj797@gmail.com>
@galasa-team
Copy link

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Member

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-simplatform-pr-160-sj89d for details. If you are unable to do so, please contact a member of the Galasa team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants