Skip to content

Excerpt will display properly if there are chinese-japanese-korean characters. #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prconcepcion wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Excerpt will display properly if there are chinese-japanese-korean characters. #2262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
294922a
Fixes excerpt if there are cjk chars.
Apr 25, 2022
4ad9a8a
Merge branch 'develop' into fix/2203-chinese-excerpt-length
May 6, 2022
b902ccb
Changed implementation.
May 6, 2022
2c67ee5
Added comments.
May 6, 2022
1c12f91
Removed function.
May 6, 2022
4b5171f
Changed the conditional.
May 6, 2022
31d2f02
Changed spacing.
May 10, 2022
9f55252
Changed implementation.
May 10, 2022
4b51d48
Changed implementation.
May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/block/posts/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,25 @@ function generate_render_item_from_stackable_posts_block( $post, $attributes, $t

// Trim the excerpt.
if ( ! empty( $excerpt ) ) {
$untrimmed_excerpt = $excerpt;
$excerpt = explode( ' ', $excerpt );
$trim_to_length = (int) $excerpt_length;
if ( count( $excerpt ) > $trim_to_length ) {
// Check if there are CJK characters.
if ( function_exists( 'mb_substr' ) && preg_match_all( "/\p{Han}+/u", $untrimmed_excerpt, $matches ) ) {
// Remove the <p> tags.
$untrimmed_excerpt = substr( $untrimmed_excerpt, 3, strlen( $untrimmed_excerpt ) - 8 );

if ( strlen( $untrimmed_excerpt ) > $trim_to_length ) {
// Trim according to string length.
$excerpt = mb_substr( $untrimmed_excerpt, 0, $trim_to_length ) . '...';
} else {
$excerpt = $untrimmed_excerpt;
}
} elseif ( count( $excerpt ) > $trim_to_length ) {
$excerpt = implode( ' ', array_slice( $excerpt, 0, $trim_to_length ) ) . '...';
} else {
$excerpt = implode( ' ', $excerpt );
$excerpt = $untrimmed_excerpt;
}

$excerpt = wp_kses_post( $excerpt );
$new_template = str_replace( '!#excerpt!#', $excerpt, $new_template );
} else {
Expand Down
15 changes: 14 additions & 1 deletion src/block/posts/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,20 @@ export const generateRenderPostItem = attributes => {

// Trim the excerpt.
let excerptString = postExcerptStackable.split( ' ' )
if ( excerptString.length > ( excerptLength || 55 ) ) {

//Checks if there are CJK characters present.
const regexCJK = /[\u3040-\u30ff\u3400-\u4dbf\u4e00-\u9fff\uf900-\ufaff\uff66-\uff9f]/

if ( postExcerptStackable.match( regexCJK ) ) {
// Remove the <p> tags.
const tempExcerptString = postExcerptStackable.substring( 3, postExcerptStackable.length - 5 )

if ( tempExcerptString.length > ( excerptLength || 55 ) ) {
excerptString = tempExcerptString.substring( 0, excerptLength === '' ? 55 : excerptLength ) + '...'
} else {
excerptString = tempExcerptString
}
} else if ( excerptString.length > ( excerptLength || 55 ) ) {
excerptString = excerptString.slice( 0, excerptLength || 55 ).join( ' ' ) + '...'
} else {
excerptString = post.post_excerpt_stackable
Expand Down