Skip to content

Update dependency jest to v29.7.0#1919

Merged
holgerkoser merged 5 commits into
masterfrom
enh/upgrade-jest
Jun 14, 2024
Merged

Update dependency jest to v29.7.0#1919
holgerkoser merged 5 commits into
masterfrom
enh/upgrade-jest

Conversation

@holgerkoser
Copy link
Copy Markdown
Member

@holgerkoser holgerkoser commented Jun 13, 2024 •
edited
Loading

What this PR does / why we need it:

  • Update dependency jest to v29.7.0:

  • Fixed problems in monitor package:

    • Fixed acceptance tests
    • Added package validations to Dockerfile

  • Suppress <Suspense> warning when running frontend test

  • Update base alpine image to v3.20

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@ghost ghost added the needs/review Needs review label Jun 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2024
@ghost ghost added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Jun 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 13, 2024
@holgerkoser holgerkoser changed the title Update dependency jest to v29.17.0 Update dependency jest to v29.7.0 Jun 13, 2024
petersutter
petersutter reviewed Jun 13, 2024
View reviewed changes
Comment thread .ci/pipeline_definitions
steps:
check:
image: 'node:20-alpine3.18'
image: 'node:20-alpine3.20'
Copy link
Copy Markdown
Member

@petersutter petersutter Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, seems like the renovate custom manager does not work in this case 🤔

dashboard/.github/renovate.json5

Lines 18 to 24 in c279ce4

{
// Generic detection for pod-like image specifications.
customType: "regex",
fileMatch: ["^\.ci\/pipeline_definitions$"],
matchStrings: ["image: ['\"]?(?<depName>.*?):(?<currentValue>.*?)['\"]?\\s"],
datasourceTemplate: "docker"
},

Copy link
Copy Markdown
Member Author

@holgerkoser holgerkoser Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Copy Markdown
Member Author

@holgerkoser holgerkoser Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also no update for the node image in the Dockerfile

Comment thread packages/monitor/__tests__/acceptance/api.metrics.test.js Outdated
@holgerkoser holgerkoser requested a review from petersutter June 13, 2024 12:55
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 13, 2024
petersutter
petersutter approved these changes Jun 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost ghost added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jun 14, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 14, 2024
@holgerkoser holgerkoser merged commit d0e27b9 into master Jun 14, 2024
@ghost ghost added the status/closed Issue is closed (either delivered or triaged) label Jun 14, 2024
@holgerkoser holgerkoser deleted the enh/upgrade-jest branch June 14, 2024 10:42
holgerkoser added a commit that referenced this pull request Jun 14, 2024
@holgerkoser
Merge branch 'master' into enh/debug-vitest
a22c26a 
* master:
  Update dependency vue-router to v4.3.3 (#1907)
  Update Yarn to v4.3.0 (#1910)
  Update dependency jest to v29.7.0 (#1919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu Awaiting requested review from grolu grolu is a code owner

Assignees

No one assigned

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2