Skip to content

Fixes bug with project create and pins sass to 1.74.1 #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petersutter merged 2 commits into from
Jul 31, 2024
Merged

Fixes bug with project create and pins sass to 1.74.1 #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc897b8
fixes #2008
holgerkoser Jul 29, 2024
fb8f5a5
Do not update sass until vuetify https://github.com/vuetifyjs/vuetify…
holgerkoser Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .pnp.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file renamed ...sass-npm-1.77.8-d0ad322666-2bfd627940.zip → ...sass-npm-1.74.1-8ef77a6612-4610257ee2.zip
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion backend/lib/services/projects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ exports.create = async function ({ user, body }) {
const client = user.client

const name = _.get(body, 'metadata.name')
_.set(body, 'metadata.namespace', `garden-${name}`)
_.set(body, 'spec.namespace', `garden-${name}`)
let project = await client['core.gardener.cloud'].projects.create(body)

const isProjectReady = ({ type, object: project }) => {
Expand Down
2 changes: 2 additions & 0 deletions backend/test/__snapshots__/services.projects.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ exports[`services/projects #create should create a project and return it when re
{
"metadata": {
"name": "foo",
},
"spec": {
"namespace": "garden-foo",
},
"status": {
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"eslint-plugin-vue": "^9.23.0",
"jsdom": "^24.0.0",
"rollup-plugin-visualizer": "^5.12.0",
"sass": "^1.72.0",
"sass": "~1.74.1",
"unplugin-fonts": "^1.1.1",
"vite": "^5.1.6",
"vite-plugin-compression": "^0.5.1",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ __metadata:
netmask: "npm:^2.0.2"
pinia: "npm:^2.1.7"
rollup-plugin-visualizer: "npm:^5.12.0"
sass: "npm:^1.72.0"
sass: "npm:~1.74.1"
semver: "npm:^7.6.0"
socket.io-client: "npm:^4.7.5"
splitpanes: "npm:^3.1.5"
Expand Down Expand Up @@ -8317,16 +8317,16 @@ __metadata:
languageName: node
linkType: hard

"sass@npm:^1.72.0":
version: 1.77.8
resolution: "sass@npm:1.77.8"
"sass@npm:~1.74.1":
version: 1.74.1
resolution: "sass@npm:1.74.1"
dependencies:
chokidar: "npm:>=3.0.0 <4.0.0"
immutable: "npm:^4.0.0"
source-map-js: "npm:>=0.6.2 <2.0.0"
bin:
sass: sass.js
checksum: 10c0/2bfd62794070352c804f949e69bd8bb5b4ec846deeb924251b2c3f7b503170fb1ae186f513f0166907749eb34e0277dee747edcb78c886fb471aac01be1e864c
checksum: 10c0/4610257ee27823276ce4998a534b4ee9f313e5a0b3d3899e70e0f87096feeae4cd8dd3c2f765b52f57dd87f5dab22370ef63f95a837a189fbb9401396d5ce717
languageName: node
linkType: hard

Expand Down