Skip to content

Volume minimum size fixes / improvements#2030

Merged
grolu merged 7 commits into
masterfrom
bug/fix_min_volume_size
Oct 4, 2024
Merged

Volume minimum size fixes / improvements#2030
grolu merged 7 commits into
masterfrom
bug/fix_min_volume_size

Conversation

@grolu
Copy link
Copy Markdown
Member

@grolu grolu commented Aug 12, 2024 •
edited
Loading

What this PR does / why we need it:

  • Fixed reactivity for volume minimum size hint
  • Added support for other size suffixes

Which issue(s) this PR fixes:
Fixes #1949

Special notes for your reviewer:

Release note:

Fixed display issues with minimum volume size

@grolu
Fixed minimum volume size hint reactivity
291c1ee 
Added support for other size suffixes
@ghost ghost added the needs/review Needs review label Aug 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2024
@ghost ghost added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 12, 2024
petersutter
petersutter reviewed Aug 15, 2024
View reviewed changes
Comment thread frontend/src/utils/index.js Outdated
@grolu
Merge branch 'master' into bug/fix_min_volume_size
567fb67 
# Conflicts:
#	frontend/src/utils/index.js
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 24, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 24, 2024
@ghost ghost added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@ghost ghost added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2024
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 4, 2024
holgerkoser
holgerkoser approved these changes Oct 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost ghost added reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Oct 4, 2024
@grolu grolu merged commit ce7911c into master Oct 4, 2024
@ghost ghost added the status/closed Issue is closed (either delivered or triaged) label Oct 4, 2024
@grolu grolu deleted the bug/fix_min_volume_size branch October 4, 2024 13:20
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 14, 2024
@grolu grolu mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersutter petersutter petersutter left review comments

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees

No one assigned

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong display of volume minSize in shoot creation

5 participants

@grolu @holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2