Skip to content

[DRAFT] Support Vendor Branding#2467

Closed
grolu wants to merge 5 commits into
masterfrom
ccp/vendor_branding
Closed

[DRAFT] Support Vendor Branding#2467
grolu wants to merge 5 commits into
masterfrom
ccp/vendor_branding

Conversation

@grolu
Copy link
Copy Markdown
Member

@grolu grolu commented Jun 2, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1707 Fixes #207 (partly)

Special notes for your reviewer:

TODOs

  • Discuss: Do we really want to support vendor-assets or is encoding image in config enough for now?
  • Discuss: Do we want to deprecate vendorHints config and move hints to the new vendor configs?
  • Add Documentation (after PR review / when API is stable)
  • Update helm charts (after PR review / when API is stable)
  • Update tests (after PR review / when API is stable)

Release note:

Define order, name and icon of cloud providers in dashboard configuration. Also allow custom names and icons for machine image vendors.

grolu added 2 commits May 22, 2025 11:16
KebabCase display name for secrets
@ghost ghost added needs/review Needs review needs/rebase Needs git rebase labels Jun 2, 2025
@ghost
Copy link
Copy Markdown

ghost commented Jun 2, 2025

@grolu You need rebase this pull request with latest master branch. Please check.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 2, 2025
@ghost ghost added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Jun 2, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 2, 2025
# Conflicts:
#	frontend/src/views/GCredentials.vue
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2025
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2025
Support vendor sorting and hiding
@ghost ghost added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 4, 2025
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 4, 2025
@ghost
Copy link
Copy Markdown

ghost commented Jun 5, 2025

@klocke-io, @holgerkoser You have pull request review open invite, please check

@grolu grolu marked this pull request as draft August 19, 2025 08:52
# Conflicts:
#	frontend/src/store/cloudProfile/index.js
#	frontend/src/store/config.js
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Sep 25, 2025
@grolu grolu changed the title Support Vendor Branding [DRAFT] Support Vendor Branding Oct 1, 2025
@grolu
Copy link
Copy Markdown
Member Author

grolu commented Dec 1, 2025

/close in favor of #2695

@ghost
Copy link
Copy Markdown

ghost commented Dec 1, 2025

@grolu Branch ccp/vendor_branding has been deleted.

@ghost ghost closed this Dec 1, 2025
@ghost ghost deleted the ccp/vendor_branding branch December 1, 2025 14:47
@ghost ghost added the status/closed Issue is closed (either delivered or triaged) label Dec 1, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to brand infrastructures / cloud profiles Sort Cloud Profiles

3 participants