[hotfix-1.83] Update undici to v7.24.6#2853
Merged
Merged
Conversation
petersutter
requested review from
grolu,
holgerkoser and
klocke-io
as code owners
gardener-prow
Bot
added
needs-rebase
gardener-prow
Bot
added
size/S
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughUpdated Node.js runtime from 22.18.0 to 22.22.0 across CI, Docker, and package configurations. Replaced Showdown with Unified/Remark/Rehype for markdown processing. Added SecretBinding-to-CredentialsBinding migration feature with new API endpoints, components, and documentation. Updated credentials handling for optional secret bindings. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User/Frontend
participant API as Backend API
participant Markdown as Markdown Engine
participant Sanitizer as Sanitize HTML
participant DB as Kubernetes API
User->>API: Request with HTML content<br/>(config, tickets, etc)
activate API
API->>Markdown: convertAndSanitize(text)
activate Markdown
Markdown->>Markdown: Parse with remark-parse<br/>Apply remark-gfm, remark-emoji
Markdown->>Markdown: Convert to HAST<br/>with remark-rehype
Markdown->>Sanitizer: Pass HTML string
activate Sanitizer
Sanitizer->>Sanitizer: Filter tags/attributes<br/>Enforce target="_blank"
Sanitizer-->>Markdown: Sanitized HTML
deactivate Sanitizer
Markdown-->>API: Promise<sanitized HTML>
deactivate Markdown
API-->>User: Response with<br/>sanitized HTML
deactivate API
sequenceDiagram
participant User as User/Frontend
participant Dialog as Migration Dialog
participant API as Backend API
participant K8s as Kubernetes API
participant Store as Credential Store
User->>Dialog: Open migrate dialog<br/>for SecretBinding
activate Dialog
Dialog->>Dialog: Load existing<br/>CredentialsBindings
Dialog->>User: Show create step or<br/>completion step
User->>Dialog: Confirm migration
Dialog->>API: createInfraCredential<br/>(new CredentialsBinding)
activate API
API->>K8s: Create CredentialsBinding
activate K8s
K8s-->>API: Binding created
deactivate K8s
API-->>Dialog: Success
deactivate API
Dialog->>User: Show shoots needing<br/>credential update
User->>Dialog: (Optional) Update shoots<br/>to use new binding
Dialog->>API: updateShootCredentialName
activate API
API->>K8s: Patch shoot credential-binding-name
K8s-->>API: Updated
deactivate API
API-->>Dialog: Success
Dialog->>Store: Refresh credential list
Dialog-->>User: Close dialog
deactivate Dialog
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM label has been added. DetailsGit tree hash: d8d0bb451adc6631b90f83a012f7f0f36124da53 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grolu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
Bot
added
the
approved
|
Caution Review failedAn error occurred during the review process. Please try again later. 📝 WalkthroughWalkthroughUpdated Node.js runtime from 22.18.0 to 22.22.0 across CI, Docker, and package configurations. Replaced Showdown with Unified/Remark/Rehype for markdown processing. Added SecretBinding-to-CredentialsBinding migration feature with new API endpoints, components, and documentation. Updated credentials handling for optional secret bindings. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User/Frontend
participant API as Backend API
participant Markdown as Markdown Engine
participant Sanitizer as Sanitize HTML
participant DB as Kubernetes API
User->>API: Request with HTML content<br/>(config, tickets, etc)
activate API
API->>Markdown: convertAndSanitize(text)
activate Markdown
Markdown->>Markdown: Parse with remark-parse<br/>Apply remark-gfm, remark-emoji
Markdown->>Markdown: Convert to HAST<br/>with remark-rehype
Markdown->>Sanitizer: Pass HTML string
activate Sanitizer
Sanitizer->>Sanitizer: Filter tags/attributes<br/>Enforce target="_blank"
Sanitizer-->>Markdown: Sanitized HTML
deactivate Sanitizer
Markdown-->>API: Promise<sanitized HTML>
deactivate Markdown
API-->>User: Response with<br/>sanitized HTML
deactivate API
sequenceDiagram
participant User as User/Frontend
participant Dialog as Migration Dialog
participant API as Backend API
participant K8s as Kubernetes API
participant Store as Credential Store
User->>Dialog: Open migrate dialog<br/>for SecretBinding
activate Dialog
Dialog->>Dialog: Load existing<br/>CredentialsBindings
Dialog->>User: Show create step or<br/>completion step
User->>Dialog: Confirm migration
Dialog->>API: createInfraCredential<br/>(new CredentialsBinding)
activate API
API->>K8s: Create CredentialsBinding
activate K8s
K8s-->>API: Binding created
deactivate K8s
API-->>Dialog: Success
deactivate API
Dialog->>User: Show shoots needing<br/>credential update
User->>Dialog: (Optional) Update shoots<br/>to use new binding
Dialog->>API: updateShootCredentialName
activate API
API->>K8s: Patch shoot credential-binding-name
K8s-->>API: Updated
deactivate API
API-->>Dialog: Success
Dialog->>Store: Refresh credential list
Dialog-->>User: Close dialog
deactivate Dialog
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update undici to v7.24.6
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: