Update dependency vue-router to v5.0.7#2966
Conversation
gardener-ci-robot
requested review from
grolu,
holgerkoser,
klocke-io and
petersutter
as code owners
gardener-ci-robot
added
kind/enhancement
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
Bot
added
cla: yes
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe ChangesYarn Plug'n'Play Dependency Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.pnp.cjs:
- Around line 176-187: The lockfile now pins a release-candidate Babel package
("npm:8.0.0-rc.5" / `@babel/generator`, `@babel/parser`, `@babel/types`) introduced
via the vue-router 5.0.7 upgrade; replace or avoid this pre-release by either
rolling back the vue-router upgrade, forcing a stable Babel version resolution,
or adding an explicit nohoist/override to resolve `@babel/`* to a stable release
(e.g., Babel 7.x) in your dependency resolution strategy so the lockfile no
longer contains "npm:8.0.0-rc.5"; update package constraints and regenerate the
lockfile (or document and accept the RC risk in the release notes if you
intentionally keep it).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d318212d-1968-4e91-b15f-9ce1ce0b4617
⛔ Files ignored due to path filters (12)
.yarn/cache/@babel-generator-npm-7.29.1-b1bf16fe79-349086e687.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@babel-generator-npm-8.0.0-rc.5-4706f3867f-fe32beaaa8.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@babel-helper-string-parser-npm-8.0.0-rc.5-834e4827dc-4058708a20.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@babel-helper-validator-identifier-npm-8.0.0-rc.5-5dd7b7785d-734bdc5ad5.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@babel-parser-npm-8.0.0-rc.5-2a9ec65efe-df734f88e8.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@babel-types-npm-8.0.0-rc.5-2ac6e73908-b3303df138.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@types-jsesc-npm-2.5.1-3d8289fff0-12ba7bf596.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@vue-devtools-api-npm-8.1.2-9a07bc314b-7c6a64fbdf.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@vue-devtools-kit-npm-8.1.2-e4731fe2e5-4776ab0ed1.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@vue-devtools-shared-npm-8.1.2-8e8f595715-05b1b4ffb2.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/vue-router-npm-5.0.7-2d75be62c7-cd5b958749.zipis excluded by!**/.yarn/**,!**/*.zipyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
.pnp.cjs
| ["npm:8.0.0-rc.5", {\ | ||
| "packageLocation": "./.yarn/cache/@babel-generator-npm-8.0.0-rc.5-4706f3867f-fe32beaaa8.zip/node_modules/@babel/generator/",\ | ||
| "packageDependencies": [\ | ||
| ["@babel/generator", "npm:7.29.1"],\ | ||
| ["@babel/parser", "npm:7.29.2"],\ | ||
| ["@babel/types", "npm:7.29.0"],\ | ||
| ["@babel/generator", "npm:8.0.0-rc.5"],\ | ||
| ["@babel/parser", "npm:8.0.0-rc.5"],\ | ||
| ["@babel/types", "npm:8.0.0-rc.5"],\ | ||
| ["@jridgewell/gen-mapping", "npm:0.3.13"],\ | ||
| ["@jridgewell/trace-mapping", "npm:0.3.30"],\ | ||
| ["@types/jsesc", "npm:2.5.1"],\ | ||
| ["jsesc", "npm:3.1.0"]\ | ||
| ],\ | ||
| "linkType": "HARD"\ |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Is Babel 8.0.0-rc.5 stable enough for production use, and does vue-router 5.0.7 require Babel 8 or is it compatible with Babel 7?
💡 Result:
Babel 8.0.0-rc.5 is a pre-release version and is not recommended for production use [1]. As a release candidate, it is intended for testing and feedback purposes rather than stable deployment [1]. Regarding Vue Router 5.0.7, it does not require Babel 8 and is compatible with Babel 7. Vue Router 5 is primarily a transition release that merges unplugin-vue-router into the core package [2][3]. It maintains compatibility with existing build setups, and there are no breaking changes for users who are not utilizing file-based routing [2][3]. You can continue to use your existing Babel 7 configuration with Vue Router 5 [2][3].
Citations:
- 1: https://github.com/babel/babel/releases/tag/v8.0.0-rc.5
- 2: https://github.com/vuejs/router/releases/tag/v5.0.0
- 3: https://router.vuejs.org/guide/migration/v4-to-v5
🏁 Script executed:
#!/bin/bash
# Check if vue-router 5.0.7 package.json specifies Babel 8 as a required dependency
curl -s https://registry.npmjs.org/vue-router/5.0.7 | jq -r '.dependencies, .peerDependencies, .optionalDependencies' | grep -i babelRepository: gardener/dashboard
Length of output: 99
Babel 8.0.0-rc.5 is not production-ready and should not be used in releases.
The upgrade to vue-router 5.0.7 introduces Babel 8.0.0-rc.5 as a direct dependency. Release candidates are pre-release versions intended for testing only and are not recommended for production use. Either defer the vue-router upgrade until Babel 8 reaches a stable release, or explicitly document and accept the risk of using a release candidate in production.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.pnp.cjs around lines 176 - 187, The lockfile now pins a release-candidate
Babel package ("npm:8.0.0-rc.5" / `@babel/generator`, `@babel/parser`, `@babel/types`)
introduced via the vue-router 5.0.7 upgrade; replace or avoid this pre-release
by either rolling back the vue-router upgrade, forcing a stable Babel version
resolution, or adding an explicit nohoist/override to resolve `@babel/`* to a
stable release (e.g., Babel 7.x) in your dependency resolution strategy so the
lockfile no longer contains "npm:8.0.0-rc.5"; update package constraints and
regenerate the lockfile (or document and accept the RC risk in the release notes
if you intentionally keep it).
gardener-ci-robot
force-pushed
the
renovate/vue-router-5.x-lockfile
branch
from
b71cbec to
5170a93
Compare
1 participant
This PR contains the following updates:
5.0.6→5.0.7Release Notes
vuejs/router (vue-router)
v5.0.7Compare Source
🚀 Features
defineParamParser()more intuitive - by @posva (8715b)@vue/devtools-api- by @posva (87c3a)params: {}workaround in discarded params warning - by @posva and shanliuling in #2689 (c2b13)🐞 Bug Fixes
@vue/language-coreimport - by @danielroe in #2710 (8af50)View changes on GitHub
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.