Enable lz4, lz4hc and zstd compression support for zram #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moritzkirchnersap
left a comment
moritzkirchnersap
left a comment
There was a problem hiding this comment.
Config options seems to be the same as in debian, looks good!
Apart from
CONFIG_ZRAM_DEF_COMP_ZSTD=y
Which according to
sets the default zram compressor - is this needed here? What would it be in case this config option wouldn't be set? And why not set it to
CONFIG_ZRAM_DEF_COMP_LZ4
for example?
Contributor
|
Ah, I just found https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086172 via #66 |
moritzkirchnersap
approved these changes
Jan 20, 2025
Member
Author
|
@gehoern please review |
gehoern
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #66
Reference in debian: https://salsa.debian.org/kernel-team/linux/-/commit/121c3f1335d97b6938d76e7541d9c4579e83d69c