WIP: Requires cleanup and preparing for the mailing list. Bloom Filters #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garimasi514
changed the title
garimasi514
changed the title
Collaborator
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
I've got some comments for you.
t/t4215-log-bloom.sh
Outdated
Comment on lines
68
to
34
Collaborator
There was a problem hiding this comment.
Instead, focus on comparing the output from git log with and without the commit-graph using -c core.commitGraph=false.
Collaborator
There was a problem hiding this comment.
(i.e. drop this part, and I'll comment later about what to do.)
t/t4215-log-bloom.sh
Outdated
Collaborator
There was a problem hiding this comment.
for file in file1 file2 file3
do
git log --oneline -- $file >actual &&
git -c core.commitGraph=false log --oneline -- $file >expect &&
test_cmp expect actual
done
…hanged paths between a commit and its first interesting parent
garimasi514
force-pushed
the
bloomVSVersion
branch
from
245b2ae to
7179fb3
Compare
|
|
||
| static inline uint64_t get_bitmask(uint32_t pos) | ||
| { | ||
| return 1UL << (pos & (BITS_PER_BLOCK - 1)); |
There was a problem hiding this comment.
This 1UL bothers me for a ui64 return type. On a 32-bit machine, this doesn't work as expected, since UL is 32 bits.
I'd suggest something like return ((uint64_t)1) << (pos & (BITS_PER_BLOCK - 1)); or maybe
uint64_t v = 1;
return v << (pos & (BITS_PER_BLOCK - 1));
and avoid the UL vs ULL mess.
garimasi514
pushed a commit
that referenced
this pull request
Jan 6, 2020
status: deserialization wait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to contribute to Git!
Those seeking to contribute to the Git for Windows fork should see
http://gitforwindows.org/#contribute on how to contribute Windows specific
enhancements.
If your contribution is for the core Git functions and documentation
please be aware that the Git community does not use the github.com issues
or pull request mechanism for their contributions.
Instead, we use the Git mailing list (git@vger.kernel.org) for code and
documenatation submissions, code reviews, and bug reports. The
mailing list is plain text only (anything with HTML is sent directly
to the spam folder).
Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.
Please read the "guidelines for contributing" linked above!