v4.1.0-beta by garronej · Pull Request #106 · garronej/tss-react

garronej · 2022-09-04T10:40:32Z

Try out #105

garronej · 2022-09-04T17:09:20Z

package.json

+    "exports": {
+        ".": {
+            "import": "./dist/esm/index.js"
+        },
+        "./mui": {
+            "import": "./dist/esm/mui.js"
+        },
+        "./nextJs": {
+            "import": "./dist/esm/nextJs.js"
+        },
+        "./compat": {
+            "import": "./dist/esm/compat.js"
+        },
+        "./mui_compat": {
+            "import": "./dist/esm/mui_compat.js"
+        }


I ended up removing "require" as I don't see the point of keeping them. Agree @jiby-aurum ?

@garronej unfortunately I think its required, I tried it 4.1.0 and it fails to import tss-react/mui complaining that it is not defined in exports, adding the "require" back fixes them.

@jiby-aurum Thank you for the feedback, I added it back in.
It's in 4.1.1

thanks again @garronej just tested, works perfectly !

gb-jos · 2022-09-07T14:10:49Z

tsconfig.json

@@ -1,9 +1,9 @@
 {
    "compilerOptions": {
-        "module": "CommonJS",


@garronej this should not have been removed,

Yes, my bad.
The default config is for CommonJS and we overwrite some values when building for ESM....

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tss-react](https://www.tss-react.dev) ([source](https://togithub.com/garronej/tss-react)) | [`4.0.0` -> `4.6.0`](https://renovatebot.com/diffs/npm/tss-react/4.0.0/4.6.0) | [![age](https://badges.renovateapi.com/packages/npm/tss-react/4.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/tss-react/4.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/tss-react/4.6.0/compatibility-slim/4.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/tss-react/4.6.0/confidence-slim/4.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>garronej/tss-react</summary> ### [`v4.6.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.6.0) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.5.2...v4.6.0)  **Full Changelog**: garronej/tss-react@v4.5.2...v4.6.0 ### [`v4.5.2`](https://togithub.com/garronej/tss-react/releases/tag/v4.5.2) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.5.1...v4.5.2)  **Full Changelog**: garronej/tss-react@v4.5.1...v4.5.2 ### [`v4.5.1`](https://togithub.com/garronej/tss-react/releases/tag/v4.5.1) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.5.0...v4.5.1)  **Full Changelog**: garronej/tss-react@v4.5.0...v4.5.1 ### [`v4.5.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.5.0) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.4.5...v4.5.0)  **Full Changelog**: garronej/tss-react@v4.4.5...v4.5.0 ### [`v4.4.5`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.5) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.4.4...v4.4.5)  **Full Changelog**: garronej/tss-react@v4.4.4...v4.4.5 ### [`v4.4.4`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.4) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.4.3...v4.4.4)  **Full Changelog**: garronej/tss-react@v4.4.3...v4.4.4 ### [`v4.4.3`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.3) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.4.2...v4.4.3)  **Full Changelog**: garronej/tss-react@v4.4.2...v4.4.3 ### [`v4.4.2`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.2) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.4.1...v4.4.2)  **Full Changelog**: garronej/tss-react@v4.4.1...v4.4.2 ### [`v4.4.1`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.1) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.4.0...v4.4.1)  **Full Changelog**: garronej/tss-react@v4.4.0...v4.4.1 ### [`v4.4.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.4.0) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.3.4...v4.4.0)  **Full Changelog**: garronej/tss-react@v4.3.4...v4.4.0 ### [`v4.3.4`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.4) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.3.3...v4.3.4)  **Full Changelog**: garronej/tss-react@v4.3.3...v4.3.4 ### [`v4.3.3`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.3) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.3.2...v4.3.3)  **Full Changelog**: garronej/tss-react@v4.3.2...v4.3.3 ### [`v4.3.2`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.2) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.3.1...v4.3.2)  **Full Changelog**: garronej/tss-react@v4.3.1...v4.3.2 ### [`v4.3.1`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.1) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.3.0...v4.3.1)  **Full Changelog**: garronej/tss-react@v4.3.0...v4.3.1 ### [`v4.3.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.3.0) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.2.0...v4.3.0)  **Full Changelog**: garronej/tss-react@v4.2.0...v4.3.0 ### [`v4.2.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.2.0) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.1.4...v4.2.0)  **Full Changelog**: garronej/tss-react@v4.1.4...v4.2.0 ### [`v4.1.4`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.4) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.1.3...v4.1.4)  **Full Changelog**: garronej/tss-react@v4.1.3...v4.1.4 ### [`v4.1.3`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.3) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.1.2...v4.1.3)  **Full Changelog**: garronej/tss-react@v4.1.2...v4.1.3 ### [`v4.1.2`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.2) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.1.1...v4.1.2)  #### What's Changed ##### Other Changes - fix [#107](https://togithub.com/garronej/tss-react/issues/107) by [@jiby-aurum](https://togithub.com/jiby-aurum) in [https://github.com/garronej/tss-react/pull/109](https://togithub.com/garronej/tss-react/pull/109) #### New Contributors - [@jiby-aurum](https://togithub.com/jiby-aurum) made their first contribution in [https://github.com/garronej/tss-react/pull/109](https://togithub.com/garronej/tss-react/pull/109) **Full Changelog**: garronej/tss-react@v4.1.1...v4.1.2 ### [`v4.1.1`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.1) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.1.0...v4.1.1)  **Full Changelog**: garronej/tss-react@v4.1.0...v4.1.1 ### [`v4.1.0`](https://togithub.com/garronej/tss-react/releases/tag/v4.1.0) [Compare Source](https://togithub.com/garronej/tss-react/compare/v4.0.0...v4.1.0)  #### What's Changed ##### Other Changes - v4.1.0-beta by [@garronej](https://togithub.com/garronej) in [https://github.com/garronej/tss-react/pull/106](https://togithub.com/garronej/tss-react/pull/106) **Full Changelog**: garronej/tss-react@v4.0.0...v4.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

gb-jos and others added 7 commits September 3, 2022 21:54

publish both cjs and esm version

aefb3bb

Disable enable short import path

7276dd6

Bump version

ebafbe7

Adding exports for /compat /mui and /mui-compat

b66a113

Bump version

2fece98

Reference .d.ts in extra exports

b0ce4c2

Bump version

9c1d25f

garronej changed the title ~~v4.1.0-beta.0~~ v4.1.0-beta Sep 4, 2022

garronej added 14 commits September 4, 2022 16:10

Fix previous commit

6a0af07

Bump version

7c727cd

fmt

ff711e0

New attempt at making it work with ESM

5ae3bcc

Bump version

5dde22a

Fix script

4b17065

Update build script

a55b963

Bump version

ef88b87

Update file include and bump version

52058a1

Abort trying to automatically resolve to _compat

511e169

Bump version

f630fa2

Fixes

8215b4b

Bump version (changelog ignore)

478124a

Fix linking script

21055fb

garronej commented Sep 4, 2022

View reviewed changes

garronej merged commit 9cfd4a4 into main Sep 4, 2022

garronej deleted the cjs_esm branch September 4, 2022 17:10

garronej added a commit that referenced this pull request Sep 4, 2022

https://github.com/garronej/tss-react/pull/106#discussion_r962373391

86dd464

garronej mentioned this pull request Sep 7, 2022

Updating to 4.1.1 caused import error #107

Closed

gb-jos reviewed Sep 7, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

v4.1.0-beta#106

v4.1.0-beta#106
garronej merged 21 commits intomainfrom
cjs_esm

garronej commented Sep 4, 2022

Uh oh!

garronej Sep 4, 2022

Uh oh!

gb-jos Sep 4, 2022

Uh oh!

garronej Sep 4, 2022

Uh oh!

gb-jos Sep 5, 2022

Uh oh!

garronej Sep 5, 2022

Uh oh!

gb-jos Sep 7, 2022

Uh oh!

garronej Sep 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Uh oh!

Conversation

garronej commented Sep 4, 2022

Uh oh!

garronej Sep 4, 2022

Choose a reason for hiding this comment

Uh oh!

gb-jos Sep 4, 2022

Choose a reason for hiding this comment

Uh oh!

garronej Sep 4, 2022

Choose a reason for hiding this comment

Uh oh!

gb-jos Sep 5, 2022

Choose a reason for hiding this comment

Uh oh!

garronej Sep 5, 2022

Choose a reason for hiding this comment

Uh oh!

gb-jos Sep 7, 2022

Choose a reason for hiding this comment

Uh oh!

garronej Sep 7, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments