fix(cookie-picker): pass port explicitly to jsonResponse and errorResponse#33
Open
Jah-yee wants to merge 1 commit intogarrytan:mainfrom
Open
fix(cookie-picker): pass port explicitly to jsonResponse and errorResponse#33Jah-yee wants to merge 1 commit intogarrytan:mainfrom
Jah-yee wants to merge 1 commit intogarrytan:mainfrom
Conversation
…ponse The jsonResponse() and errorResponse() helper functions referenced 'url' which was not in scope - it only exists in handleCookiePickerRoute(). This caused all API routes (/cookie-picker/browsers, /domains, /import, /remove, /imported) to fail with 'ReferenceError: url is not defined'. Fix: Extract port at the top of handleCookiePickerRoute() and pass it explicitly to all jsonResponse() and errorResponse() calls. Fixes garrytan#32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The cookie picker API routes fail with
ReferenceError: url is not definedbecause thejsonResponse()anderrorResponse()helper functions referenceurlwhich is not in their scope - it only exists as a parameter inhandleCookiePickerRoute().Every API call (
/cookie-picker/browsers,/domains,/import,/remove,/imported) throwsReferenceError.Fix
Extract
portat the top ofhandleCookiePickerRoute()and pass it explicitly to alljsonResponse()anderrorResponse()calls.Fixes #32