feat: persist review artifacts and cross-session handoff#60
Open
gregario wants to merge 1 commit intogarrytan:mainfrom
Open
feat: persist review artifacts and cross-session handoff#60gregario wants to merge 1 commit intogarrytan:mainfrom
gregario wants to merge 1 commit intogarrytan:mainfrom
Conversation
plan-ceo-review, plan-eng-review, and review now save their structured outputs to .gstack/reviews/ after each run. A rolling HANDOFF.md aggregates the most recent review of each type into a session-bridging document. ship reads HANDOFF.md during pre-flight and surfaces planning context in the PR body. Closes garrytan#6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
i dont understand this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/plan-ceo-review,/plan-eng-review, and/reviewnow save their structured outputs (completion summary, error maps, failure modes, scope exclusions, diagrams, user decisions) to.gstack/reviews/after each runHANDOFF.mdaggregates the most recent review of each type into a single session-bridging document/shipreadsHANDOFF.md(if present) and adds a "Planning Context" section to the PR bodyCloses #6
Design decisions
What's saved: The Required Outputs each skill already defines — decisions and structured deliverables, not the review process or conversation. This matches the retro pattern (saves structured metrics, not the narrative) and QA pattern (saves the report, not the exploration).
Archive format: Dual-track MD + JSON per review, date-sequenced (
plan-ceo-2026-03-15-1.{md,json}). The JSON enables programmatic HANDOFF.md regeneration. This is more structured than QA (which has no per-report JSON) but the JSON is load-bearing — without it, regenerating the handoff from markdown would require parsing prose.HANDOFF.md is transient: Overwritten on each review run, like QA's
baseline.json. It's a "latest pointer," not an archive. The individual review files in.gstack/reviews/accumulate and persist — following the museum model established by retro snapshots and QA reports ("Never delete output files... accumulate — that's intentional")./shipintegration is explicit: Called out as a separate enhancement. Ship reads HANDOFF.md during pre-flight and surfaces planning context in the PR body. If no HANDOFF.md exists, the step is skipped silently.Skills without existing save state are omitted:
plan-ceo-reviewandplan-eng-reviewhad no persistence at all (only TODOS.md)./reviewpersisted findings indirectly via/ship's PR body. This PR adds direct persistence to all three.Test plan
bun run gen:skill-docs --dry-run— all SKILL.md files FRESHbun test— 66/66 skill validation tests pass/plan-ceo-review, verify.gstack/reviews/populated/ship, verify "Planning Context" in PR body when HANDOFF.md exists🤖 Generated with Claude Code