Conversation
|
Gary, the changes look great. Sorry for the hassle. This pull request is posted to your fork of the repository. Here are the instructions on how to pull request from a forked repository (called a downstream repository) back to the original repository (called the upstream repository). https://help.github.com/articles/creating-a-pull-request-from-a-fork/ It's no big deal at all. I pulled the changes from your repository and posted as a new pull request on the upstream repo. Your commits are still recorded just as if you submitted the pull request to the repository and you can view them in the pull request thread. The nice thing about creating the pull request yourself is that you can continue to push changes to your downstream repository branch after the pull request is generated and they show up in the upstream pull request automatically. No need to submit another PR. This is very helpful during code reviews as changes are made before they are merged into the upstream codebase. Let's give it another try with some other changes so that you can learn how to work with Github. It is a valuable skill to have when you work with developers and other designers in public or private repositories on Github or any of the other source hosting services. It can even be something trivial like a documentation update (just add a space to something so that the file differs from the upstream and submit a PR to me). I'll show you the workflow in a pull request once we have one that you submit. |
|
As a side note, I also frequently submit pull requests to the same repository as you've done here. It is a nice way to show your running file diffs against any of the branches in your repository and run continuous integration testing on the changes that you make. Same repository PR's also happen when teams are all committing to the same repository. They work in their own separate branches and PR against a common branch where source collects to push towards production release. This allows teams to perform code reviews before source hits the master branch of the repository. There are uses for same repo PR's. |
Added options for @1x and @2x sizes.