fix: ensure inserting <title> in <head> updates document.title
#39382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
serhalp
force-pushed
the
fix/react-head-document-title
branch
2 times, most recently
from
56b1fb3 to
ded6a14
Compare
These are nondeterministic and conflict with test output assertions
In #39306 we introduced a workaround that wraps the Gatsby Head API elements in an `<svg>` wrapper. React under the hood creates these children elements in the "SVG" namespace. In the case of `<title>`, this is problematic because when we insert it into the real `<head>`, browsers (as far as we can tell) do not trigger an update of `document.title` because this only occurs for `<title>` nodes in the HTML namespace. A node's namespace is immutable, even when using `cloneNode()` or `importNode()`. The only way to "reset" the namespace is to recreate a node.
serhalp
force-pushed
the
fix/react-head-document-title
branch
from
ded6a14 to
b2e83e8
Compare
serhalp
commented
Dec 5, 2025
| GATSBY_CPU_COUNT: 2 | ||
| COMPILER_OPTIONS: GATSBY_MAJOR=<< parameters.gatsby_major >> | ||
| NODE_NO_WARNINGS: 1 | ||
| BROWSERSLIST_IGNORE_OLD_DATA: true |
Member
Author
There was a problem hiding this comment.
This is nondeterministic and was messing with some stdout test assertions
serhalp
commented
Dec 5, 2025
| no_output_timeout: 15m | ||
| environment: | ||
| NODE_OPTIONS: --max-old-space-size=2048 | ||
| NODE_NO_WARNINGS: 1 |
Member
Author
There was a problem hiding this comment.
This was missing from this Windows job (present in the others)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #39306 we introduced a workaround that wraps the Gatsby Head API elements in an
<svg>wrapper. React under the hood creates these children elements in the "SVG" namespace.In the case of
<title>, this is problematic because when we insert it into the real<head>, browsers (as far as we can tell) do not trigger an update ofdocument.titlebecause this only occurs for<title>nodes in the HTML namespace. A node's namespace is immutable, even when usingcloneNode()orimportNode().The only way to "reset" the namespace is to recreate a node.
Documentation
N/A
Tests
Augmented existing
<title>tests to also verify the actual page titleRelated Issues
See reports here: #39180 (comment)