Added Ending After Method to Builders #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @gavynriebau, I needed a way to specify after a certain number of iterations in a recurrence to return a null date, showing that the recurrence is over. I added EndingAfter method to the builders that take in an int which specifies the number of times the user intends for the recurrence to happen.
I'm using your library to create schedules with parameters similar to Outlook or Google Calendar, where one of the options is to select is a "ends after" so many occurrences of the event. This seemed like something that might be useful to others, which is why I'm submitting this pull request. Let me know what you think.
Thanks.