Open
Conversation
added 3 commits
April 17, 2018 20:40
* Give the correct shapes for all arguments. * Check that arguments shapes are consistent. * Check that transition matrices are left stochastic in the slow version of the function. This seems like a nice thing to do for the user, as most presentations use right stochastic matrices, so it is pretty easy to get this wrong.
gbrunick
force-pushed
the
hamilton-filter-fixes
branch
from
99f765e to
23b9bfb
Compare
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 80.12% 80.14% +0.01%
==========================================
Files 560 560
Lines 84550 84609 +59
Branches 9567 9572 +5
==========================================
+ Hits 67745 67806 +61
+ Misses 14588 14583 -5
- Partials 2217 2220 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This full request features some improvements to the Hamilton filter functionality (both the Python and Cython versions).
Handles the order=0 case.
Documents the expected sizes of the arguments correctly.
Checks that the argument sizes satisfy the documented sizes.