Conversation
godronus
force-pushed
the
fix/deploy-app-outputs
branch
from
b487a58 to
37964d4
Compare
github output for URL
godronus
force-pushed
the
fix/deploy-app-outputs
branch
from
37964d4 to
ad75171
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for outputting the app_url for wasi-http applications. The changes refactor the output-setting logic into a reusable setActionOutputs helper function that conditionally sets the app_url output when available.
Changes:
- Refactored output setting into a centralized
setActionOutputshelper function - Added conditional output for
app_urlfield (available for wasi-http apps only) - Updated action metadata and documentation to reflect the new output
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/deploy-app/main.ts | Added setActionOutputs helper function to centralize output setting logic and support the new app_url output |
| dist/deploy-app/index.js | Generated JavaScript transpilation of the TypeScript changes |
| deploy-app/action.yml | Added app_url output definition to action metadata |
| deploy-app/DEPLOY-APP.md | Documented the new app_url output in the usage guide |
| badges/coverage.svg | Updated coverage badge reflecting slight decrease to 99.65% |
qrdl
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.