Adding internationalization capabilities#19
Merged
Conversation
qqmyers
requested changes
Aug 9, 2023
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Thanks for the i18n functionality. I just merged a few fixes for accessibility and support for additional checksum algorithms (the latter uses a new API call in 5.14). Can you resolve the merge conflicts from that?
FWIW: Longer term, I think it might be good to use a standard i18n solution like jquery i18n (as we do in the dataverse-previewers) but I'm happy to merge this PR to get something in place.
Contributor
Author
|
Hello @qqmyers :) After some commits, it looks ok to merge (maybe you can squash commits ) |
qqmyers
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialized with English and French
Fixed some undefined variables
Closes #18