Skip to content

Conversation

@evamaxfield
Copy link
Contributor

@evamaxfield evamaxfield commented Feb 26, 2025

Hey! Just want to say thanks for making this package as it makes it super easy to handle downloading data from dataverse!

I am trying to use the download functionality programmatically in a project of my own but I am getting conflicting typer dependency versions.

While I know that typer is still in zero-ver, to my knowledge there haven't been many breaking changes to the core of typer in a while and I have even tested these changes locally with my work which uses typer v0.15.

If we want to be a bit safer, maybe we also put an upper bound on it if you want? typer = ">=0.9.0,<1"?

@JR-1991 JR-1991 self-assigned this Feb 26, 2025
@JR-1991 JR-1991 added the enhancement New feature or request label Feb 26, 2025
@JR-1991 JR-1991 added this to the 0.3.0 milestone Feb 26, 2025
@JR-1991
Copy link
Member

JR-1991 commented Feb 26, 2025

@evamaxfield, thanks so much for the feedback and PR 🙌

You raise a great point about the strict versioning. It might not be the most advantageous approach and an easy way to enter dependecy issues. I agree that a more flexible versioning makes sense. However, I’d lean towards a safer option to guard against any potential breaking changes in 1.0.

@evamaxfield
Copy link
Contributor Author

evamaxfield commented Feb 26, 2025

Given that it all seems to be working with at least typer v0.15 shall I upbound to v0.15 v0.16?

i.e. >=0.9,<0.16

@JR-1991
Copy link
Member

JR-1991 commented Feb 26, 2025

Sounds perfect! Thanks a lot 🙌

@evamaxfield
Copy link
Contributor Author

Sounds perfect! Thanks a lot 🙌

Done!

@JR-1991 JR-1991 merged commit 5de9d0b into gdcc:main Feb 26, 2025
2 checks passed
@JR-1991
Copy link
Member

JR-1991 commented Feb 26, 2025

Merged 😁

@evamaxfield
Copy link
Contributor Author

Hey @JR-1991 any chance this can be released soon? Trying to use this change in my work and while locally I can install from pip install git+https://, somewhat challenging / frustrating in my automated pipeline setup.

@JR-1991
Copy link
Member

JR-1991 commented Mar 18, 2025

@evamaxfield I am currently finishing the next release and hope to publish it this week. This PR is still open, but mandatory for the upcoming release

Once merged and released, I will notify you 🙌

@evamaxfield
Copy link
Contributor Author

Perfect! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

2 participants