Implements set_entry method#20
Open
Cosmologist wants to merge 2 commits intogddc:masterfrom
Cosmologist:patch-1
Open
Implements set_entry method#20Cosmologist wants to merge 2 commits intogddc:masterfrom Cosmologist:patch-1
Cosmologist wants to merge 2 commits intogddc:masterfrom
Cosmologist:patch-1
Conversation
I have a task - create an entry in the module and relate it with the other entry. The problem is that the dynamic method set_enty returned dictionary, but method relate occure SugarEntry object. I changed the code, for convenience redefined the dynamic creation methods, api for easy overriding them. Created method set_entry, which works as before, only returns SugarEntry object instead dictionary, which can be used further. Sorry for bad english!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a task - create an entry in the module and relate it with the other entry.
The problem is that the dynamic method set_enty returned dictionary, but method relate occure SugarEntry object.
I changed the code, for convenience redefined the dynamic creation api methods, for easy overriding them.
Created method set_entry, which works as before, only returns SugarEntry object instead dictionary, which can be used further.
Sorry for bad english!