Activates PDK for notebook notebooks/workflow_3_cascaded_mzi.ipynb#675
Merged
joamatab merged 1 commit intogdsfactory:mainfrom Feb 24, 2026
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the cascaded MZI workflow notebook to explicitly activate the gf.gpdk PDK before use, ensuring the proper process design kit configuration is loaded for subsequent operations. Sequence diagram for activating gf_gpdk_PDK_in_cascaded_MZI_notebooksequenceDiagram
actor User
participant Notebook as workflow_3_cascaded_mzi
participant gf as gdsfactory_gf
participant gpdk as gf_gpdk
participant PDK as gf_gpdk_PDK
User->>Notebook: Run import and setup cell
Notebook->>gf: import gdsfactory as gf
Notebook->>gpdk: access gpdk attribute on gf
Notebook->>PDK: gf.gpdk.PDK.activate()
PDK-->>Notebook: Active PDK configuration set
Notebook-->>User: Subsequent operations use activated PDK
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider moving
gf.gpdk.PDK.activate()into a dedicated setup cell (e.g., clearly labeled as environment/PDK setup) so that PDK activation is isolated and easier to rerun or adjust without re-executing other imports or logic in the notebook.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving `gf.gpdk.PDK.activate()` into a dedicated setup cell (e.g., clearly labeled as environment/PDK setup) so that PDK activation is isolated and easier to rerun or adjust without re-executing other imports or logic in the notebook.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
joamatab
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #673.
Summary by Sourcery
New Features: