Skip to content

Make (gmeep) s-parameter caching more stable #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joamatab merged 1 commit into from
Feb 28, 2026
Merged

Make (gmeep) s-parameter caching more stable #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions gplugins/common/utils/get_sparameters_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from __future__ import annotations

import hashlib
import pathlib
from functools import partial
from pathlib import Path
from typing import Any
Expand All @@ -21,7 +20,7 @@ def get_kwargs_hash(**kwargs: Any) -> str:


def get_component_hash(component: gf.Component) -> str:
gdspath = pathlib.Path(component.write_gds())
gdspath = Path(component.write_gds(no_empty_cells=True, with_metadata=False))
h = hashlib.md5(gdspath.read_bytes()).hexdigest()
gdspath.unlink()
return h
Expand All @@ -42,10 +41,10 @@ def _get_sparameters_path(

"""
dirpath = dirpath or GDSDIR_TEMP / "sparameters"
dirpath = pathlib.Path(dirpath)
dirpath = Path(dirpath)
component = gf.get_component(component)

dirpath = pathlib.Path(dirpath)
dirpath = Path(dirpath)
dirpath = (
dirpath / component.name
if hasattr(component, "function_name")
Expand Down
Loading