Skip to content

Use TemporaryDirectory while hashing gds files to avoid multi-process race conditions #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gronniger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use TemporaryDirectory while hashing gds files to avoid multi-process race conditions #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions gplugins/common/utils/get_sparameters_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import hashlib
from functools import partial
from pathlib import Path
from tempfile import TemporaryDirectory
from typing import Any

import gdsfactory as gf
Expand All @@ -20,9 +21,9 @@ def get_kwargs_hash(**kwargs: Any) -> str:


def get_component_hash(component: gf.Component) -> str:
gdspath = Path(component.write_gds(no_empty_cells=True, with_metadata=False))
h = hashlib.md5(gdspath.read_bytes()).hexdigest()
gdspath.unlink()
with TemporaryDirectory() as tmpdir:
gdspath = Path(component.write_gds(gdsdir=tmpdir, no_empty_cells=True, with_metadata=False))
h = hashlib.md5(gdspath.read_bytes()).hexdigest()
return h


Expand Down
Loading