Set default value for the 'use_create_frame' argument to a data sources' start_stream() method to False, making the use of create_frames() the default #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: For writing tests, its useful to have the stream stop once the frames have been processed, so the test code doesn't have to manually stop the stream.
When a data source uses
create_frames()this happens nicely, ascreate_frames()stops the stream once all frames have been generated.However, when we have a test that processes a single file, the default of
use_create_frame=TruecausesDataSchemeFileto callcreate_frame()and then not stop the stream.