Fix retry connection on send #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The binding would attempt to reconnect in the
sendmethod if the connection wasn't established:https://github.com/edgedb/edgedb-java/blob/46c513285faffee9992e47447eb542f5c7a158ae/src/driver/src/main/java/com/edgedb/driver/binary/duplexers/ChannelDuplexer.java#L200-L213
The issue with this is that the
connectmethod on theEdgeDBBinaryClientwould be recursively called if the underlying connection was closed during the send function:The way the attempts were calculated here are locals to only the method, they're not passed down the call hierarchy so this bug would occur.
Changes
The send method will now recall itself only when an
EdgeDBExceptionis thrown with theShouldRetryflag. Any other exceptions are propagated to the caller which is responsible for handling them.