Skip to content

fix: use emoticons in changelog#8

Merged
gemmadanks merged 1 commit intomainfrom
fix-changelog
Oct 11, 2025
Merged

fix: use emoticons in changelog#8
gemmadanks merged 1 commit intomainfrom
fix-changelog

Conversation

@gemmadanks
Copy link
Copy Markdown
Owner

@gemmadanks gemmadanks commented Oct 11, 2025

Fixes key in release-please config and prevents pre-commit hook pretty-format-json converting emoticons into C/C++/Java source code.

Prerequisites checklist

Please check each of the following before merging:

  • I have updated any relevant documentation
  • I have added unit tests for any new code
  • I have linked to any relevant issues
  • I will squash my commits and, where needed, edit the commit messages to make them more informative follow the conventional commits format
  • This pull request is ready to merge (leave unchecked to indicate a WIP)

What is the purpose of this pull request?

Check all that apply:

  • Documentation update
  • Bug fix
  • New feature
  • Changes to an existing feature
  • Refactor
  • Increasing test coverage
  • Other, please explain:

Fixes key in release-please config and prevents pre-commit hook pretty-format-json converting emoticons into C/C++/Java source code.
Copilot AI review requested due to automatic review settings October 11, 2025 12:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the release-please configuration to properly use emoticons in changelog generation. The changes address issues where emoticons were being converted to unicode escape sequences by the pre-commit hook and corrects the configuration key name.

  • Updates release-please configuration to use proper key name and readable emoticons
  • Prevents pre-commit hook from converting emoticons to unicode escape sequences
  • Updates existing changelog to use emoji format

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
release-please-config.json Fixes key name from "changelog-types" to "changelog-sections" and converts unicode escape sequences to proper emoticons
CHANGELOG.md Updates existing changelog section header to use emoji format
.pre-commit-config.yaml Adds --no-ensure-ascii flag to prevent emoticon conversion

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gemmadanks gemmadanks merged commit fa3f6af into main Oct 11, 2025
24 checks passed
@gemmadanks gemmadanks deleted the fix-changelog branch October 11, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants