Merged
Conversation
Fixes key in release-please config and prevents pre-commit hook pretty-format-json converting emoticons into C/C++/Java source code.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the release-please configuration to properly use emoticons in changelog generation. The changes address issues where emoticons were being converted to unicode escape sequences by the pre-commit hook and corrects the configuration key name.
- Updates release-please configuration to use proper key name and readable emoticons
- Prevents pre-commit hook from converting emoticons to unicode escape sequences
- Updates existing changelog to use emoji format
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| release-please-config.json | Fixes key name from "changelog-types" to "changelog-sections" and converts unicode escape sequences to proper emoticons |
| CHANGELOG.md | Updates existing changelog section header to use emoji format |
| .pre-commit-config.yaml | Adds --no-ensure-ascii flag to prevent emoticon conversion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes key in release-please config and prevents pre-commit hook pretty-format-json converting emoticons into C/C++/Java source code.
Prerequisites checklist
Please check each of the following before merging:
What is the purpose of this pull request?
Check all that apply: